Hmm, I’m struggling getting that PR to work. I’ve pulled it in locally, kicked up the docker dev environment, but I can’t get the checkboxes to show with or without markdown-it enabled.
I’ve even completely destroyed the docker dev environment and re-initialized.
Figured it out, this errant return; statement
However, there is already : with the current implementation, given the following, it breaks
 Item One
[*] Item Two (should be checked)
[ ] Item Three
[*] Item Four (should also be checked)
Actual output:, Items Two through Four are italized.
I’ve got that fixed, however, now with markdown-it turned off, the fix for the italize is causing checking a checkbox to not show properly (preview pane shows it properly though when you edit the post afterwards).
It is only breaking with markdown-it disabled. But for the life of me, I haven’t a clue why, as when I trace it down, it is replacing
[\*] with the appropriate
span tag and classes, but when it saves the post, the
[\*] reappears from seemingly nowhere…
Granted, this can happen with
[_] as well on new markdown-it, but that value can’t be generated by clicking the checkbox, so the user should see the issue and escape it before it is submitted. Only
[*] is capable of being written based on the user clicking a box.
Updated PR to look at (which has your PR and the fixes I described above – and the issue with markdown-it disabled)