Configured "read only banner" on category disables new topic button in theme component

[RGJ (Richard - Communiteq)]

Problem:

when

• the New Topic Button theme component is installed
• “Banner text when a user cannot create a topic in this category:” is configured on a category
• the user does have permissions to create topics in the category

then

• the new topic button is disabled
• a tooltip “you do not have permission to create new topics here” shows

expected:

• the new topic button is not disabled since the user does have permissions

the mere fact that a banner text is configured is not a reason to assume the user does not have permissions.

@awesomerobot See code

@yigit this is the root cause of the issue we discussed yesterday

[awesomerobot (Kris)]

Thanks for reporting it! just merged a fix: FIX: don't disable based on banner condition by awesomerobot · Pull Request #11 · discourse/discourse-new-topic-button-theme-component · GitHub