Convert to topic icon missing

ondrej · November 3, 2024, 9:50pm

When you make a PM into a topic the icon seems to be missing as you can see in the image below.

This is in the topic admin actions in a PM

Lilly · November 3, 2024, 9:57pm

oh it’s there all right, it’s just not showing because of some shenanigans, possibly fontawesome 6 not being awseome… lol

Thanks for the heads up!

awesomerobot · November 4, 2024, 2:48pm

I just converted this to a PM and back to a topic and it seems the icon appears correctly?

it looks like this is expecting a different icon for some reason…

edit: looking at the code for small actions, it appears it falls back to “exclamation” when a matching icon can’t be found… but the public_topic does have an icon defined… the plot thickens

Firepup650 · November 4, 2024, 6:42pm

I’m not sure that’s ever worked on our forum, we have many silly posts that were made into actions as a joke, and none of those have icons visible.

Moin · December 29, 2024, 1:53pm

That happens because Meta is a public site. The action code is different in that case.

github.com

discourse/discourse/blob/e9d4afec534349e9934cbd608f57ed010a61fd79/app/serializers/post_serializer.rb#L477-L480


      
          def action_code
            return "open_topic" if object.action_code == "public_topic" && SiteSetting.login_required?
            object.action_code
          end

There is different text when login required is enabled.

github.com

discourse/discourse/blob/e9d4afec534349e9934cbd608f57ed010a61fd79/config/locales/client.en.yml#L171-L173


      
          action_codes:
            public_topic: "Made this topic public %{when}"
            open_topic: "Converted this to a topic %{when}"

I think the problem is that while there is an icon for “public_topic”, there is no icon defined for “open_topic”.

github.com

discourse/discourse/blob/e9d4afec534349e9934cbd608f57ed010a61fd79/app/assets/javascripts/discourse/app/widgets/post-small-action.js#L54-L77


      
          const icons = {
            "closed.enabled": "lock",
            "closed.disabled": "unlock-keyhole",
            "autoclosed.enabled": "lock",
            "autoclosed.disabled": "unlock-keyhole",
            "archived.enabled": "folder",
            "archived.disabled": "folder-open",
            "pinned.enabled": "thumbtack",
            "pinned.disabled": "thumbtack unpinned",
            "pinned_globally.enabled": "thumbtack",
            "pinned_globally.disabled": "thumbtack unpinned",
            "banner.enabled": "thumbtack",
            "banner.disabled": "thumbtack unpinned",
            "visible.enabled": "far-eye",
            "visible.disabled": "far-eye-slash",
            split_topic: "right-from-bracket",
            invited_user: "circle-plus",
            invited_group: "circle-plus",
            user_left: "circle-minus",
            removed_user: "circle-minus",

This file has been truncated. show original

awesomerobot · January 6, 2025, 6:33pm

Ah that explains it! thanks for figuring that out

This PR will add the icon:

github.com/discourse/discourse

UX: add missing icon for `open_topic` small action

discourse:main ← discourse:ux-open-topic-action

opened 06:32PM - 06 Jan 25 UTC

awesomerobot

+1 -0

Investigated here: https://meta.discourse.org/t/convert-to-topic-icon-missing/33…4309/8?u=awesomerobot When a site is set to `login_required` the small action for converting a PM to a topic is `open_topic` rather than `public_topic` — and there's no icon defined for it. This adds one (the same as `public_topic`). Before: ![image](https://github.com/user-attachments/assets/cb271177-38af-4d68-a849-8c5a1ffe85cc) After: ![image](https://github.com/user-attachments/assets/4a8b47e0-b913-423d-81a0-a81c12c0276a)

Topic		Replies	Views
Text when converting PM to Topic doesn't work for login-required forums UX	5	703	January 12, 2022
New PM Dropdown Button Theme component official , pm-dropdown	8	5603	May 4, 2023
Converted topic posts to message can not convert back to topic Support	7	517	October 26, 2022
Convert a private message to public topic or vice versa Feature feedback	15	6888	October 21, 2016
Top topics text missing Bug fixed	7	75	August 16, 2024

Convert to topic icon missing

Related topics