Discourse calendar plugin failing on stable branch

bug
1

Hi guys,

At the time of precompiling assets, there is a glitch by using the Discourse calendar plugin.

...
Done compressing all JS files : 82.84 secs

Start compiling CSS: 2020-01-14 13:20:06 UTC
Compiling css for default 2020-01-14 13:20:06 UTC
precompile target: desktop Dark
rake aborted!
Discourse::ScssError: Error: no mixin named ellipsis
        on line 36 of plugins/discourse-calendar/assets/stylesheets/common/discourse-calendar.scss
        from line 28 of desktop.scss
>>       @include ellipsis;

   ---------------^
/var/www/discourse/lib/stylesheet/manager.rb:175:in `rescue in compile'
/var/www/discourse/lib/stylesheet/manager.rb:163:in `compile'
/var/www/discourse/lib/stylesheet/manager.rb:98:in `block (2 levels) in precompile_css'
/var/www/discourse/lib/stylesheet/manager.rb:91:in `each'
/var/www/discourse/lib/stylesheet/manager.rb:91:in `block in precompile_css'
/var/www/discourse/lib/stylesheet/manager.rb:90:in `each'
/var/www/discourse/lib/stylesheet/manager.rb:90:in `precompile_css'
/var/www/discourse/lib/tasks/assets.rake:59:in `block (2 levels) in <top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rails_multisite-2.0.7/lib/rails_multisite/connection_management.rb:63:in `with_connection'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rails_multisite-2.0.7/lib/rails_multisite/connection_management.rb:73:in `each_connection'
/var/www/discourse/lib/tasks/assets.rake:52:in `block in <top (required)>'
/var/www/discourse/lib/tasks/assets.rake:318:in `block in <top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rake-12.3.2/exe/rake:27:in `<top (required)>'
/usr/local/bin/bundle:23:in `load'
/usr/local/bin/bundle:23:in `<main>'

Caused by:
SassC::SyntaxError: Error: no mixin named ellipsis
        on line 36 of plugins/discourse-calendar/assets/stylesheets/common/discourse-calendar.scss
        from line 28 of desktop.scss
>>       @include ellipsis;

   ---------------^
/var/www/discourse/plugins/discourse-calendar/assets/stylesheets/common/discourse-calendar.scss:36
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/sassc-2.0.1/lib/sassc/engine.rb:49:in `render'
/var/www/discourse/lib/stylesheet/compiler.rb:40:in `compile'
/var/www/discourse/lib/stylesheet/compiler.rb:22:in `compile_asset'
/var/www/discourse/lib/stylesheet/manager.rb:164:in `compile'
/var/www/discourse/lib/stylesheet/manager.rb:98:in `block (2 levels) in precompile_css'
/var/www/discourse/lib/stylesheet/manager.rb:91:in `each'
/var/www/discourse/lib/stylesheet/manager.rb:91:in `block in precompile_css'
/var/www/discourse/lib/stylesheet/manager.rb:90:in `each'
/var/www/discourse/lib/stylesheet/manager.rb:90:in `precompile_css'
/var/www/discourse/lib/tasks/assets.rake:59:in `block (2 levels) in <top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rails_multisite-2.0.7/lib/rails_multisite/connection_management.rb:63:in `with_connection'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rails_multisite-2.0.7/lib/rails_multisite/connection_management.rb:73:in `each_connection'
/var/www/discourse/lib/tasks/assets.rake:52:in `block in <top (required)>'
/var/www/discourse/lib/tasks/assets.rake:318:in `block in <top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rake-12.3.2/exe/rake:27:in `<top (required)>'
/usr/local/bin/bundle:23:in `load'
/usr/local/bin/bundle:23:in `<main>'
Tasks: TOP => assets:precompile:css
(See full trace by running task with --trace)
...

Any hint?

Cheers,
Ismael

1 Like
2

Hello,

can you tell me your Discourse version please ?

3 Likes
3

Hi Joffrey,

It’s stable branch, so should point to v2.3.8 in theory.

Cheers,
Ismael

4

Hi,
Any news on this?

5

Yes, I found the root cause.

I thought it has been for longer than this, but actually the ellipsis mixin has been added recently:

https://github.com/discourse/discourse/commit/b066a4128d0971c16ab88ef1673115e4a7d16a54

I have been fouled by the fact that we are using it in local-dates, but as local-dates is a core plugin it can’t be out of sync of core functions.

This should be fixed by:
https://github.com/discourse/discourse-calendar/commit/e735f87d5b0668c75fa087975e20f0fe8e160b2d

If you try again that should work, sorry and thanks for report.

8 Likes
6

Yeah, confirm it works! :clap: Big thank you for your quick action!

Cheers,
Ismael

2 Likes
7

Cool, thanks for update!

1 Like