Discourse doesn't render in Firefox when notifications are disabled

Bug
1

Tested with Firefox on safe mode / no addons. Win 7. FF 59.0.1 (64-bit). Have noticed this for the past month or so. User is presented with a blank/white screen on all forum pages. Apparently this effects all discourse sites for users that have

dom.webnotifications.enabled = false

in about.config. This is not an uncommon setting, it would be great if this could be fixed so that having notifications disabled won’t render block the entire site.

Console error output:

4 Likes
2

I got ‘Internal Server Error’ here when posting the full bug report.

More info here:


4

This was due to a bug in discourse-push-notifications and has been fixed in

https://github.com/discourse/discourse-push-notifications/commit/8e217c492dabfd578c69ef5ef491ee9887c5ec12

Thanks for reporting @steveb

13 Likes
5

Many thanks for the prompt fix! You rock @tgxworld

3 Likes