Discourse-setup: assumes nc is installed

Внести вклад Ошибка
1

Ran through the install using discourse-setup (I don’t think I ever have yet, so no time like the present!) and the following error showed up:

Checking your domain name . . .
WARNING:: This server does not appear to be accessible at dotest.example.net:443.

A connection to http://dotest.example.net (port 80) also fails.

This suggests that dotest.example.net resolves to the wrong IP address
or that traffic is not being routed to your server.

Google: "open ports YOUR CLOUD SERVICE" for information for resolving this problem.

You should probably answer "n" at the next prompt and disable Let's Encrypt.

This test might not work for all situations,
so if you can access Discourse at http://dotest.example.net, you might try anyway.

I believe this happened as nc isn’t installed so it couldn’t properly run the test. We should ensure nc is available before erroring out on this check.

3 лайка
2

I totally believe that I assumed that nc was installed and that on some OSs it’s not.

The messages do suggest that it could be wrong. Did Let’s Encrypt work?

What OS is this? What cloud service?

2 лайка
3

Fresh debian-9 on DO.

Everything else worked A-OK and it’s up and running great! :+1:

3 лайка
4

Hmm. Then the question becomes, does discourse-doctor install nc just for one test that might not be necessary, or just say, “well, you don’t have nc, so you’re on your own to see that you have ports open and mapped correctly.”?

I don’t like installing software if it’s not necessary. I think I’ll change the message to recommend installing nc if they want it.

@codinghorror? @mpalmer want to weigh in?

5

Wasn’t this addressed in a different way by @supermathie?

6

I’m all for this :+1:

I addressed the problem where Discourse’s email test rake task didn’t properly pick up the STARTTLS option. This is separate.

2 лайка
7

In that case either stop the script and tell them to re-run with nc installed, or print a warning that the check was skipped because nc was not installed?

2 лайка
8

I was going to let the script continue with the warning, adding the bit about nc. As it is, it does work, it just suggests that it probably won’t.

4 лайка
9

Можно закрыть это как выполненное, @pfaffman?

10

Что ж, прошло уже 6 месяцев. Я не добавил сообщение «у вас нет nc, поэтому я не могу проверить ваши порты», но никто не жаловался. Возможно, формулировки достаточно:

     Google: \"open ports YOUR CLOUD SERVICE\" для получения информации по решению этой проблемы.
    
     Скорее всего, на следующем запросе следует ответить \"n\" и отключить Let's Encrypt.
    
     Этот тест может не сработать во всех случаях,
     поэтому, если вы можете получить доступ к Discourse по адресу http://$HOST, попробуйте всё же.

Это никогда не было :bug:, а лишь раздражением для тех, кто обладает достаточными знаниями системного администратора и не хочет использовать Ubuntu. На Ubuntu всё работает как ожидалось (я не проверял другие дистрибутивы). Я склонен оставить всё как есть и не трогать спящую собаку.

5 лайков