Discourse Staff Alias

fokx · May 24, 2024, 9:06am

I meet the same error every time I reply to some post that is not OP:

An error occurred: You are not permitted to view the requested resource.

After digging into this a little bit, I find the culprit lies at:

discourse/discourse-staff-alias/blob/5e1855a2321c32a8fd4c78988954fa57f29b9cb9/lib/discourse_staff_alias/posts_controller_extension.rb#L17


      
          prepended do
            include WithCurrentUser
          
            around_action do |controller, action|
              if DiscourseStaffAlias::CONTROLLER_ACTIONS.include?(action_name = controller.action_name) &&
                   (params = controller.params).dig(
                     *DiscourseStaffAlias::CONTROLLER_PARAMS[action_name],
                   ) == "true"
                existing_user = controller.current_user
          
                if !DiscourseStaffAlias.user_allowed?(existing_user) || params[:whisper]
                  raise Discourse::InvalidAccess
                end
          
                alias_user = DiscourseStaffAlias.alias_user
                alias_user.aliased_user = existing_user
          
                controller.with_current_user(alias_user) { action.call }
              else
                action.call
              end

The problem is:

params[:whisper] is "false", which is a String, so simply change this line to:

if !DiscourseStaffAlias.user_allowed?(existing_user) || params[:whisper] == "true"

…will solve the issue.

I made a simple PR: FIX: InvalidAccess when replying to non-original post by fokx · Pull Request #67 · discourse/discourse-staff-alias · GitHub

Topic		Replies	Views
Can it be used for more than one alias? Support staff-alias	2	269	June 10, 2023
Multiple Users posting under same User or Group name? Support	7	1289	May 11, 2021
Allow users with access to discourse-staff-alias plugin to send an initial DM as a staff message Feature staff-alias	0	21	July 31, 2024
Discourse API, is it possible to create a Post through a different username? Support	2	851	March 25, 2022
Can the Staff Alias also be used for replies? Support staff-alias	2	287	June 10, 2023

Discourse Staff Alias

Related topics