sok777
(sok)
October 3, 2023, 7:53pm
1
I noticed there’s a broken feature.
using /unread, when clicking the dismiss and checking the ‘stop tracking’ option it doesn’t actually untrack the topics it dismisses.
To repro-
go to /unread
Open one of the unread topics
Click dismiss then check the checkbox
All topics will be dismissed, now check the open topic and see that it is still tracked
Any thoughts?
4 Likes
rubeno
(Ruben Oussoren)
October 4, 2023, 6:12pm
10
Hi @sok777 ,
Thank for flagging this bug! I was able to replicate the issue with your replication steps and have passed it onto our developers to take a further look into this. We’ll keep you posted on any updates. Your help in improving Discourse is much appreciated!
4 Likes
Thank you for reporting this bug. It was fixed with this PR :
discourse:main
← lis2:fix-dismiss-unread-untrack
opened 02:13AM - 11 Oct 23 UTC
Bug introduced when dismiss modal was moved to new component-based API - https:/… /github.com/discourse/discourse/pull/22262
We need to track `dismissTopics` property to send correct request to server.
Meta: https://meta.discourse.org/t/dismiss-all-unread/280948
Demo
https://github.com/discourse/discourse/assets/72780/6f2881b0-f37d-41c5-bad5-c51c8219274b
5 Likes