Do not swap Approve / Reject buttons in the spam queue!

awesomerobot · November 9, 2026, 9:17pm

I already had this started based on an earlier topic, completing it here:

UX: ensure reviewables all share the same yes/no direction (#45915)

main ← ux-review-queue-direction

02:35PM - 12 Nov 26 UTC

This is enabled under a beta upcoming change `Consistent review queue answers` s…o sites that need adjustment time can opt-out if needed. Based on feedback in https://meta.discourse.org/t/do-not-swap-approve-reject-buttons-in-the-spam-queue/375951?u=awesomerobot and other similar topics linked within. Previously we had a mix of directions for questions in the review queue: * Approve this user? yes = approve * Is this post spam? yes = penalize This can cause confusion and mental overhead in situations where moderators are quickly reviewing many items in the queue. As an alternative, this change re-frames all our questions in the direction of: * "Is there something wrong with this post / topic / account? So "yes" always confirms a problem and there's no flip-flopping. <img width="1380" height="260" alt="image" src="https://github.com/user-attachments/assets/086b2058-b36c-462c-885a-1e351f652216" /> <img width="1380" height="260" alt="image" src="https://github.com/user-attachments/assets/cb3d9d59-e17f-48fa-8366-87dbd589aa0d" /> This also revises the badges and filters on reviewed content to share a single direction as well. Previously we had: * Flag approved (which means there was something wrong) = green badge * Post rejected (which also means there was something wrong) = red badge Instead we can apply * "problem confirmed" = red * "no problem found" = green <img width="1380" height="254" alt="image" src="https://github.com/user-attachments/assets/107740d4-1dc7-4994-adcc-7bd49b3b9561" /> <img width="1380" height="266" alt="image" src="https://github.com/user-attachments/assets/48a97474-6c0c-4e7d-a35b-8cf93a13cb16" /> Additionally: - "Yes" is always the first button - Resolved approval items (e.g. a rejected queued post) no longer show the question... they show "Moderator actions" with an explicit "Approve post" button. - The timeline matches the badge: "Problem confirmed by …" / "No problem found by …" instead of "Approved by" / "Rejected by". - The status filter offers "Problem confirmed" / "No problem found" instead of "Approved" / "Rejected". - The labels use new i18n keys instead of editing the old "Yes"/"No" strings, so stale translations can't show the opposite meaning. - The questions are whole sentences per noun, which makes translation simpler for gendered languages

and a corresponding update for Akismet (just to fix specs based on the core change)

DEV: update specs for core change (#223)

main ← dev-update-specs-core-change

awesomerobot

02:21PM - 11 Nov 26 UTC

+51 -5

This corresponds with core renaming of the review page object's status helpers b…y outcome rather than by status, because "approved" means opposite things for flags and for approval-style items (https://github.com/discourse/discourse/pull/45915) - `have_reviewable_with_approved_status` → `have_reviewable_with_problem_confirmed_status` - `have_reviewable_with_rejected_status` → `have_reviewable_with_no_problem_found_status` All of this plugin's reviewables are flag-style: confirming spam sets `approved` (problem confirmed) and "not spam" sets `rejected` (no problem found). So they keep core's default `approval_style? = false` and no model changes are needed. The specs fall back to the old helper names when core doesn't have the new ones, following the existing `confirm_deletion` pattern.

Topic		Replies	Views
Confused by "Approve" and "Reject" in the review queue Product Support	14	3671	December 9, 2020
Approving or rejecting what? The flag or the post? Feature	10	3097	April 23, 2019
Inconsistent meaning of Yes/No actions in the review queue UX review-queue	6	221	November 12, 2026
UX: Moderator actions have visual bugs after #36812 Bug review-queue , ux	1	155	January 14, 2026
Unify review queue buttons UX review-queue	0	229	May 24, 2024

Do not swap Approve / Reject buttons in the spam queue!

Related topics