Редактирование таблицы с пустыми заголовками заполняет их текстом по умолчанию («Столбец A», «Столбец B»…)

Lhc_fl · 12.Июль.2024 16:44:32

Этот PR должен это исправить

github.com/discourse/discourse

FIX: Don't let table-build automatically fill empty headers with default values (#27894)

main ← table-builder-keep-empty-headers

merged 04:41PM - 12 Jul 24 UTC

Lhcfl

+34 -3

The old table builder would fill empty headers with default values A~Z when edit…ing. This commit makes table-builder respect the old empty headers. This is due to a behavior of jspreadsheet that cannot be turned off (see https://bossanova.uk/jspreadsheet/v4/docs/getting-started#Header-titles ). We have to pass in a value that cannot be implicitly converted to false in the JavaScript sense. In this case, we pass in a space, which is the same as the empty string in the visual sense. before: The table-builder will fill the empty header with the default values of A~Z and save it. after: Allows an empty header (strictly speaking, it is a space `" "`) ![image](https://github.com/user-attachments/assets/7b9d72ce-92a4-4959-ac09-2d164d45a80d) related meta topic: https://meta.discourse.org/t/editing-a-table-with-empty-headers-fills-them-in-with-the-default-text-column-a-column-b/268472

Тема		Ответов	Просм.
Editing a table whose some rows don't start with a pipe duplicate these rows Bug pr-welcome , table-builder	0	609	15.06.2023
Creating a table sometimes insert empty lines between rows, breaking the table Bug table-builder , fixed	7	647	05.07.2024
A first-timer's experience with the Table Builder Feature table-builder	0	430	25.01.2024
Table Builder Component broken? Bug table-builder	5	696	25.04.2023
Copying a table, without a tHead, from my clipboard, into the editor, converts its top-most TR's TD into a TH Bug	0	69	10.04.2026

Редактирование таблицы с пустыми заголовками заполняет их текстом по умолчанию («Столбец A», «Столбец B»…)

Связанные темы