Edits not properly reset with Shared Drafts


(Joshua Rosenfeld) #1

Used the new Shared Drafts feature when writing up Discourse 2.0.0.beta5 Release Notes today. Prior to publishing the topic I made 2 edits. After publishing the topic I made another edit, which I then hid via “hide revision”.

Expected Results:

Anonymous viewer: no edits seen.
Non-staff user: no edits seen.
Staff user: 1 edit seen (but hidden).

Actual Results:

:x: Anonymous viewer: 3 edits seen. Blank edit history modal.
:x: Non-staff user: 3 edits seen. Blank edit history modal.
:white_check_mark: Staff user: 1 edit seen (but hidden)


Anon/logged in user view:

cc @eviltrout

An aside (maybe a bug?) - the grace edit window didn’t seem to apply after publishing. The post publishing edit was made with 10 seconds of publishing the posts, and changed less characters than the editing grace period max diff high trust (400). I’d expect it to be a grace edit and thus not logged?


(Robin Ward) #2

Fixed here. I didn’t realize there’s a public_version that’s separate from the private_version:


(Robin Ward) #3

(Robin Ward) #4

Also, this should fix the ninja editing: