I’d like emails to include the “Re:” in replies to aid subject threading in dumber mail clients (most annoyingly including Apple’s Mail.app). I coded this up and even submitted a pull request (thanks for looking at it @eviltrout). But then one of my users asked if it was possible to add the category to the subject line. I’m not sure I want to do this, but it is certainly reasonably so I’d like to look at adding a user configurable subject line with appropriate parameters available (ala reply by email address “%{reply_key}” token).
This would apply to user_replied, user_quoted, user_mentioned, user_posted - I don’t think the others need further configuration options.
However, one thing I don’t understand though is in the English translations, and a few of the other translations (including zh_CN) all four are the same subject, namely “[%{site_name}] %{topic_title}” - that would mean all four could be done in one setting and no translations are needed.
However in most of the translations (including zh_TW), all four are different and include the username and text about the reply/mention/quote, and even extra text in the normal user_posted subject, eg:
subject_template: “[%{site_name}] %{subject_prefix}%{username} 在 ‘%{topic_title}’ 討論話題發表了文章”
I would assume that irrespective of language, the basic format of all the subjects should be the same, so my guess is that originally, the English originally included custom emails for each type, and this was translated, and then the english removed this and the new translations have taken not, but the old ones remain.
And indeed, looking at the “Blame” history for the line in the english translation shows @sam made a change in December “FIX: Custom email subjects (x quoted you in [title], x replied to [title]) was removed, this broke email grouping. TBD, include info in footer somehow”
https://github.com/discourse/discourse/commit/db1d01d1a269a3b9d3d2a67d4b49b1c442ab9f66
So given this, I would guess that we could have a single config for email subject (for the four normal types) which looked like this: “%{optional_re}[%{site_name}] %{topic_title}” and that could include category and username and perhaps other tokens if desired by the user, but would be the same format for all four and would not be translated.
Any thoughts?