Emoji group name causes issues

piffy · February 12, 2024, 7:12am

To reproduce:

go to /admin/customize/emojis and add a new emoji. Create a new emoji Group called set and add the emoji under that set. Emoji name and image is arbitrary.

Now go to any topic and click the reply button. The composer fails to load properly (there is no post button at the bottom). Browser console points here

Uncaught (in promise) TypeError: groups[emoji.group].push is not a function

github.com

discourse/discourse/blob/6b596151ff714c57fed50197d995b3981b46c52d/app/assets/javascripts/discourse/app/components/emoji-picker.js#L26


      
          import discourseComputed, {
            bind,
            observes,
          } from "discourse-common/utils/decorators";
          
          function customEmojis() {
            const list = extendedEmojiList();
            const groups = [];
            for (const [code, emoji] of list.entries()) {
              groups[emoji.group] = groups[emoji.group] || [];
              groups[emoji.group].push({
                code,
                src: emojiUrlFor(code),
              });
            }
            return groups;
          }
          
          export default Component.extend({
            emojiStore: service("emoji-store"),
            tagName: "",

Removing all emoji in the group fixes the issue.

Arkshine · February 12, 2024, 1:39pm

I can reproduce as well.

The name “set” conflicts with the array prototype functions such as set().

I think an easy fix would be to use an object instead: const groups = {}; – this should still work in the template.

Topic		Replies	Views
Some Emoji show broken Bug	6	1494	February 20, 2017
Emoji in topic names 😛💜🍦 Feature	8	1741	September 28, 2015
Emoji adder issue Bug	6	687	June 2, 2020
How to create a new emoji set Support	6	2162	February 1, 2019
Problem adding custom emojis Bug	9	1125	January 3, 2017

Emoji group name causes issues

Related Topics