Steps to reproduce
Write something in the editor (for example: test
) and then type :
Choose “more…”
Choose any of the emojis (for example: “smile”).
Expected behavior
smile:
gets appended after the first :
, resulting in test :smile:
Actual behavior
smile:
gets appended at the beginning of the message, resulting in smile: test :
6 Likes
sam
(Sam Saffron)
June 16, 2022, 3:39am
4
Oh … this could possibly related to the recent “textarea” history work @david ?
Thanks for the repro steps @Nacho_Caballero … confirmed.
4 Likes
Any idea why my post appears edited even though there was no edit? I often see phantom edits like this
2 Likes
sam
(Sam Saffron)
June 16, 2022, 5:41am
6
Oh sorry … that is me, I added an internal private priority medium tag to signal to the dev managers that I want to make sure that work starts within 30 days ;p
It is an interesting problem cause we probably want to hide the fact it was edited in cases like that except to the group that can see the edit.
6 Likes
david
(David Taylor)
June 16, 2022, 10:30am
8
Yup it was - sorry about that! Here’s a fix and a new test which would have caught this issue:
discourse:main
← discourse:emoji-insert
opened 10:29AM - 16 Jun 22 UTC
In the specific case where you start typing an emoji, then open the full emoji p… icker, the chosen emoji would be inserted in the wrong place. This was an unintentional side effect of the changes in 75d9c16156f79f5a9f30a04433c3cb0ae82d914c
This commit updates the `emojiSelected` logic to avoid mutating the 'selected' object, and also adds a test for this specific behaviour.
6 Likes
david
(David Taylor)
Closed
June 20, 2022, 7:00am
9
This topic was automatically closed after 3 days. New replies are no longer allowed.