Empty class values in hamburger menu

Bug
1

While experimenting with decorateWidget, I discovered that the li tags in the hamburger menu have a class attribute with an empty string as the value.

The hamburger menu widget does add classes to the links within the list items, so CSS is not entirely impossible.

I’m guessing this was an over-sight when the header was revamped. But as no one has squawked about it and they don’t seem to be causing any problems as they are, maybe they could simply be removed and they could be targeted using nth-child (or kin) when need be?

5 Likes
2

@eviltrout your call on what to do here.

1 Like
3

I think you’re right that the class attribute should not be there when there’s no class present. Here’s a fix:

https://github.com/discourse/discourse/commit/9d4405d602bd8d13bfc74b13f9d4b9fa96e9ab97

3 Likes