En.category.settings_sections.event_sorting broken

Moin · October 23, 2024, 2:45pm

I noticed a broken text

Edit: the settings are affected too

The string exists

discourse/discourse-calendar/blob/main/config/locales/client.en.yml#L381-L385


      
          category:
            sort_topics_by_event_start_date: "Sort topics by event start date."
            disable_topic_resorting: "Disable topic resorting."
            settings_sections:
              event_sorting: "Event Sorting"

sam · October 24, 2024, 5:01am

Oh thanks for reporting, we had tons of duplicate translations so we moved a big pile of stuff around.

We will get this sorted!

joffreyjaffeux · October 24, 2024, 6:36am

Yes thanks for the report, that will fix it:

github.com/discourse/discourse-calendar

FIX: category settings for calendar were incorrect

discourse:main ← discourse:category-settings-translations

opened 06:33AM - 24 Oct 24 UTC

jjaffeux

+36 -25

Following the key change in https://github.com/discourse/discourse-calendar/comm…it/d31933bf4963ad8c107e9a9c0e8349a2b96145ad this has been broken. This commit also hides the section if `sort_categories_by_event_start_date_enabled` AND `disable_resorting_on_categories_enabled` are not enabled, prior to this change we would just show the title, with no checkbox to check.

I also fixed another small bug while I was at it.

Topic		Replies	Views
Error with categories with limited visibility and/or subcategories Bug	15	717	November 2, 2023
Discourse calendar no longer shows any events (in some browsers only) Bug calendar-and-event	16	822	October 14, 2023
Category topics not sorted correctly Support	3	735	July 6, 2020
Enabling the Calendar plugin disables sorting by Replies and Views in Latest Bug calendar-and-event	4	462	October 23, 2022
Category links should honor category order settings Bug	6	484	September 11, 2023

En.category.settings_sections.event_sorting broken

Related Topics