Error al agregar sinónimo de etiqueta cuando ambas ya existen en un tema

Overgrow · 29 Febrero, 2020 13:14

It seems like current code can’t handle creating synonyms in case that the topic already contained both tags before creating a synonym.

Started POST "/tag/solstrip/synonyms" for 3.14.14.5 at 2020-02-29 12:07:28 +0000
Processing by TagsController#create_synonyms as */*
  Parameters: {"synonyms"=>["solstrips"], "tag_id"=>"solstrip"}
Completed 500 Internal Server Error in 46ms (ActiveRecord: 0.0ms | Allocations: 6385)
ActiveRecord::RecordNotUnique (PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "index_topic_tags_on_topic_id_and_tag_id"
DETAIL:  Key (topic_id, tag_id)=(14651, 310) already exists.
)
/var/www/discourse/vendor/bundle/ruby/2.6.0/gems/rack-mini-profiler-1.1.6/lib/patches/db/pg.rb:69:in `exec_params'
Failed to handle exception in exception app middleware : PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "index_topic_tags_on_topic_id_and_tag_id"
DETAIL:  Key (topic_id, tag_id)=(14651, 310) already exists.

github.com/discourse/discourse

lib/discourse_tagging.rb

c31039d51


      
          # Returns true if all were added successfully, or an Array of the
          # tags that failed to be added, with errors on each Tag.
          def self.add_or_create_synonyms_by_name(target_tag, synonym_names)
            tag_names = DiscourseTagging.tags_for_saving(synonym_names, Guardian.new(Discourse.system_user)) || []
            existing = Tag.where_name(tag_names).all
            target_tag.synonyms << existing
            (tag_names - target_tag.synonyms.map(&:name)).each do |name|
              target_tag.synonyms << Tag.create(name: name)
            end
            successful = existing.select { |t| !t.errors.present? }
            TopicTag.where(tag_id: successful.map(&:id)).update_all(tag_id: target_tag.id)
            Scheduler::Defer.later "Update tag topic counts" do
              Tag.ensure_consistency!
            end
            (existing - successful).presence || true
          end
          
          def self.muted_tags(user)
            return [] unless user
            TagUser.lookup(user, :muted).joins(:tag).pluck('tags.name')
          end

Can anybody please confirm it and probably move to #bugs ? Thx!

justani · 28 Abril, 2020 15:22

Yes, this issue is happening on our discourse installation too.

supermathie · 17 Julio, 2020 21:17

Confirmed this is still happening on latest code.

sam · 21 Julio, 2020 00:40

@vinothkannans can you sort this out?

vinothkannans · 21 Julio, 2020 15:33

This is now fixed in the below commit

Tema		Respuestas	Vistas
Internal Server Error on using some tags (ERROR: duplicate key value violates unique constraint "index_tags_on_name") Bug	20	3275	12 Noviembre 2019
Adding synonym to the same tag gets stuck Bug	11	1326	23 Noviembre 2020
Main tag sharing same name and url with synonym Support	0	590	28 Junio 2020
New Tags Creation Feature tags , completed	20	1139	16 Abril 2024
There are some duplicated tags due to database corruption and I can't merge Support	13	1752	24 Diciembre 2023

Error al agregar sinónimo de etiqueta cuando ambas ya existen en un tema

Temas relacionados