١. خطأ بسيط في تجربة المستخدم (UX) في discourse-subscriptions.
حل طلب السحب هذا الفراغ الذي كان يظهر عند زيارة صفحة الملف الشخصي للمستخدمين الآخرين.
main ← small-lovely-cat:discourse-subscriptions-whitespace-fix
opened 03:40AM - 03 Dec 25 UTC
The original discourse-subscriptions plugin uses a condition rendering logic to … make sure the button doesn't exist on other users' main page.
However, the logic doesn't consider the parent node `<li id="ember136" class="user-main-nav-outlet billing ember-view">`. As a matther of fact, there exists a blank space that takes space and make the nav-bar misaligned.
This PR change the condition rendering logic `{{#if this.viewingSelf}}` to the class `@classNameBindings("viewingSelf::hidden")`, so that the whole element can hide entirely without leaving a blank space.
Before:
<img width="918" height="750" alt="image" src="https://github.com/user-attachments/assets/79cf0886-a77c-467c-a00c-b06a3ae3a2eb" />
After:
<img width="982" height="837" alt="image" src="https://github.com/user-attachments/assets/cea5139c-ffff-4a99-a1fb-b537ebc98c94" />
٢. إصلاح مشكلة حلقة التحميل عند حذف موضوع.
main ← small-lovely-cat:post-stream-loading-loop-fix
opened 05:21AM - 03 Dec 25 UTC
In #35409, a fix has been implemented to fix the loading loop when a topic is re… moved.
However, that PR hasn't fully solved that problem, when admin enable the new post-stream setting, the fetch api will be `findPostsByIds`->`loadIntoIdentityMap` rather than the original `fetchNextWindow`, causing a regression.
This PR adds the same logic to the `loadIntoIdentityMap` function, so that the logic work as well in the new setting.
يضيف طلب السحب هذا نفس المنطق إلى واجهة برمجة التطبيقات (API) loadIntoIdentityMap التي تتعامل مع حلقة التحميل عند حذف منشور، عندما يتم تمكين تدفق المنشورات الجديد (post-stream).
يرجى تخصيص وقت لمراجعتها.
@cvx @pmusaraj
3 إعجابات