Gif icon not displaying and showing error

having this same issue, only it was working yesterday. I then added cdn+s3 uploads+cdn and it has stopped working. Everything else works properly, both cdn pulls work well. Using DO Spaces + Bunny CDN.
Tried clearing both cdn pulls’ cache, didn’t matter, the GIF svg doesn’t load properly.

2 Likes

I’ve got another site that’s doing something strange with svg on an S3 bucket. I haven’t figured out what’s going on, though.

2 Likes

The GIF text icon disappeared and after trying to delete and reinstall the component I’m getting this error.

Error with icons-sprite: #<TypeError: no implicit conversion of nil into String>

Button works but the GIF sprite is not visible.

2 Likes

Hi, is there any solution to this? @Falco

It’s weird to see that Meta has it’s GIF sprite in place. We are currently at 2.8.1 (stable) and yet to upgrade to 2.8.2, but the problem persists before that when we were at “latest”, around a month or so ago.

1 Like

Just letting everyone know that if you revert this whole commit, the icon gets back in place in the editor.

I now wonder why no more people report this bug and why isn’t it being reproduced here at meta?

We’re going to update to v2.8.3 +2 this week and I will double check if it’s compatible with current state of GitHub - discourse/discourse-gifs repository

1 Like

Unfortunately, the issue is not resolved in 2.8.3 too.

1 Like

Have you tried deleting the component and adding it again? maybe the old icon name is stuck somewhere. That commit you previously mentioned reverting only changed the name of the included icon, so it shouldn’t be something that relies on a certain Discourse version.

2 Likes

I just tried your advice, and that’s what I got at component page in admin (there was no such error before that):

Error with icons-sprite: #<TypeError: no implicit conversion of nil into String>

Screenshot

I took a note of this error, and proceeded to save my API key and no, it doesn’t fix the issue with composer icon.

1 Like

Are we the only one running into this problem? Anyone? For the past week, there were many changes introduced to main repo of this component by Discourse devs, but none of those solve the problems of:

  • Missing GIF icon in composer
  • Error of “Error with icons-sprite: #<TypeError: no implicit conversion of nil into String>”
2 Likes

We use S3 storage if it matters at all…

1 Like

We actually see this error on the DiscoTOC component page as well:


The logs are saying:

DiscoTOC theme contains a corrupt svg upload : OpenURI::HTTPError : 403 Error

We tried by de-install & re-install it. Could it be a “simple” permission error on the server only?

1 Like

Hey @Jonathan_Poyer,

Were you able to resolve the issue by yourself? Why do you think the issue is related to filesystem permissions on the server?

1 Like

The logs seemed to point towards the upload.
We have since updated some chmod and updated to latest and it was magically solved!

2 Likes

why can’t I use the tenor and this appears?

2 Likes

We experience the same issue for months and have no “GIF” icon in our composer.

It was reported here:
https://meta.discourse.org/t/discourse-gifs/158738/214?u=kinetiksoft
and here:
https://meta.discourse.org/t/discourse-gifs/158738/211?u=kinetiksoft

But it seems like the problem affects very small amount of people and nobody can help identifying it…

We don’t even have the directory system tries to find SVG in.

1 Like

What’s interesting is that gif.svg in the component repository is totally blank itself:

1 Like

It also may be the component is not S3 compatible, but I am not sure. It worked before, it stopped working correctly some time back in 2022 when it was first reported here.

1 Like

Meta uses S3 and the icon works here.

1 Like

Hello. I would like to inform, that the issue still persists, it’s definitely been more than a year since we have no GIF icon in our composer.

image


Since then, the error in the Components Admin section changed to:

Error with icons-sprite: #<TypeError: no implicit conversion of nil into String>

And the logs now show different message in regards to these problems. Which affect DiscoTOC too (but I found no visual issues with it, and it is rarely used):

Missing ThemeSvgSprites for theme 5, uploads 51, 1619

Full error details

Message (4255 copies reported)
Missing ThemeSvgSprites for theme 5, uploads 51, 1619

Backtrace

/var/www/discourse/lib/svg_sprite.rb:308:in `block in theme_svgs’

/var/www/discourse/lib/distributed_cache.rb:18:in `defer_get_set’

/var/www/discourse/lib/svg_sprite.rb:495:in `get_set_cache’

/var/www/discourse/lib/svg_sprite.rb:296:in `theme_svgs’

/var/www/discourse/lib/svg_sprite.rb:331:in `custom_svgs’

/var/www/discourse/lib/svg_sprite.rb:385:in `bundle’

/var/www/discourse/lib/svg_sprite.rb:353:in `block in version’

/var/www/discourse/lib/distributed_cache.rb:18:in `defer_get_set’

/var/www/discourse/lib/svg_sprite.rb:495:in `get_set_cache’

/var/www/discourse/lib/svg_sprite.rb:352:in `version’

/var/www/discourse/lib/svg_sprite.rb:358:in `path’

/var/www/discourse/app/helpers/application_helper.rb:698:in `client_side_setup_data’

/var/www/discourse/app/views/layouts/application.html.erb:73:in `_app_views_layouts_application_html_erb___1577556886474134849_230700’

actionview-7.0.4.3/lib/action_view/base.rb:244:in `public_send’

actionview-7.0.4.3/lib/action_view/base.rb:244:in `_run’

actionview-7.0.4.3/lib/action_view/template.rb:157:in `block in render’

activesupport-7.0.4.3/lib/active_support/notifications.rb:208:in `instrument’

actionview-7.0.4.3/lib/action_view/template.rb:361:in `instrument_render_template’

actionview-7.0.4.3/lib/action_view/template.rb:155:in `render’

rack-mini-profiler-3.1.0/lib/mini_profiler/profiling_methods.rb:85:in `block in profile_method’

actionview-7.0.4.3/lib/action_view/renderer/template_renderer.rb:76:in `block in render_with_layout’

activesupport-7.0.4.3/lib/active_support/notifications.rb:206:in `block in instrument’

activesupport-7.0.4.3/lib/active_support/notifications/instrumenter.rb:24:in `instrument’

activesupport-7.0.4.3/lib/active_support/notifications.rb:206:in `instrument’

actionview-7.0.4.3/lib/action_view/renderer/template_renderer.rb:74:in `render_with_layout’

actionview-7.0.4.3/lib/action_view/renderer/template_renderer.rb:59:in `render_template’

actionview-7.0.4.3/lib/action_view/renderer/template_renderer.rb:11:in `render’

actionview-7.0.4.3/lib/action_view/renderer/renderer.rb:61:in `render_template_to_object’

actionview-7.0.4.3/lib/action_view/renderer/renderer.rb:29:in `render_to_object’

actionview-7.0.4.3/lib/action_view/rendering.rb:117:in `block in _render_template’

actionview-7.0.4.3/lib/action_view/base.rb:270:in `in_rendering_context’

actionview-7.0.4.3/lib/action_view/rendering.rb:116:in `_render_template’

actionpack-7.0.4.3/lib/action_controller/metal/streaming.rb:216:in `_render_template’

actionview-7.0.4.3/lib/action_view/rendering.rb:103:in `render_to_body’

actionpack-7.0.4.3/lib/action_controller/metal/rendering.rb:46:in `render_to_body’

actionpack-7.0.4.3/lib/action_controller/metal/renderers.rb:141:in `render_to_body’

actionpack-7.0.4.3/lib/abstract_controller/rendering.rb:25:in `render’

actionpack-7.0.4.3/lib/action_controller/metal/rendering.rb:30:in `render’

actionpack-7.0.4.3/lib/action_controller/metal/instrumentation.rb:22:in `block (2 levels) in render’

/usr/local/lib/ruby/3.2.0/benchmark.rb:311:in `realtime’

activesupport-7.0.4.3/lib/active_support/core_ext/benchmark.rb:14:in `ms’

actionpack-7.0.4.3/lib/action_controller/metal/instrumentation.rb:22:in `block in render’

actionpack-7.0.4.3/lib/action_controller/metal/instrumentation.rb:91:in `cleanup_view_runtime’

activerecord-7.0.4.3/lib/active_record/railties/controller_runtime.rb:34:in `cleanup_view_runtime’

actionpack-7.0.4.3/lib/action_controller/metal/instrumentation.rb:21:in `render’

/var/www/discourse/app/controllers/categories_controller.rb:89:in `block (2 levels) in index’

actionpack-7.0.4.3/lib/action_controller/metal/mime_responds.rb:214:in `respond_to’

/var/www/discourse/app/controllers/categories_controller.rb:57:in `index’

actionpack-7.0.4.3/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action’

actionpack-7.0.4.3/lib/abstract_controller/base.rb:215:in `process_action’

actionpack-7.0.4.3/lib/action_controller/metal/rendering.rb:53:in `process_action’

actionpack-7.0.4.3/lib/abstract_controller/callbacks.rb:234:in `block in process_action’

activesupport-7.0.4.3/lib/active_support/callbacks.rb:118:in `block in run_callbacks’

/var/www/discourse/app/controllers/application_controller.rb:414:in `block in with_resolved_locale’

i18n-1.12.0/lib/i18n.rb:322:in `with_locale’

/var/www/discourse/app/controllers/application_controller.rb:414:in `with_resolved_locale’

activesupport-7.0.4.3/lib/active_support/callbacks.rb:127:in `block in run_callbacks’

activesupport-7.0.4.3/lib/active_support/callbacks.rb:138:in `run_callbacks’

actionpack-7.0.4.3/lib/abstract_controller/callbacks.rb:233:in `process_action’

actionpack-7.0.4.3/lib/action_controller/metal/rescue.rb:22:in `process_action’

actionpack-7.0.4.3/lib/action_controller/metal/instrumentation.rb:67:in `block in process_action’

activesupport-7.0.4.3/lib/active_support/notifications.rb:206:in `block in instrument’

activesupport-7.0.4.3/lib/active_support/notifications/instrumenter.rb:24:in `instrument’

activesupport-7.0.4.3/lib/active_support/notifications.rb:206:in `instrument’

actionpack-7.0.4.3/lib/action_controller/metal/instrumentation.rb:66:in `process_action’

actionpack-7.0.4.3/lib/action_controller/metal/params_wrapper.rb:259:in `process_action’

activerecord-7.0.4.3/lib/active_record/railties/controller_runtime.rb:27:in `process_action’

actionpack-7.0.4.3/lib/abstract_controller/base.rb:151:in `process’

actionview-7.0.4.3/lib/action_view/rendering.rb:39:in `process’

rack-mini-profiler-3.1.0/lib/mini_profiler/profiling_methods.rb:85:in `block in profile_method’

actionpack-7.0.4.3/lib/action_controller/metal.rb:188:in `dispatch’

actionpack-7.0.4.3/lib/action_controller/metal.rb:251:in `dispatch’

actionpack-7.0.4.3/lib/action_dispatch/routing/route_set.rb:49:in `dispatch’

actionpack-7.0.4.3/lib/action_dispatch/routing/route_set.rb:32:in `serve’

actionpack-7.0.4.3/lib/action_dispatch/routing/mapper.rb:18:in `block in class:Constraints

actionpack-7.0.4.3/lib/action_dispatch/routing/mapper.rb:48:in `serve’

actionpack-7.0.4.3/lib/action_dispatch/journey/router.rb:50:in `block in serve’

actionpack-7.0.4.3/lib/action_dispatch/journey/router.rb:32:in `each’

actionpack-7.0.4.3/lib/action_dispatch/journey/router.rb:32:in `serve’

actionpack-7.0.4.3/lib/action_dispatch/routing/route_set.rb:852:in `call’

/var/www/discourse/lib/middleware/omniauth_bypass_middleware.rb:74:in `call’

rack-2.2.7/lib/rack/tempfile_reaper.rb:15:in `call’

rack-2.2.7/lib/rack/conditional_get.rb:27:in `call’

rack-2.2.7/lib/rack/head.rb:12:in `call’

actionpack-7.0.4.3/lib/action_dispatch/http/permissions_policy.rb:38:in `call’

/var/www/discourse/lib/content_security_policy/middleware.rb:12:in `call’

/var/www/discourse/lib/middleware/anonymous_cache.rb:369:in `call’

/var/www/discourse/config/initializers/008-rack-cors.rb:24:in `call’

rack-2.2.7/lib/rack/session/abstract/id.rb:266:in `context’

rack-2.2.7/lib/rack/session/abstract/id.rb:260:in `call’

actionpack-7.0.4.3/lib/action_dispatch/middleware/cookies.rb:704:in `call’

actionpack-7.0.4.3/lib/action_dispatch/middleware/callbacks.rb:27:in `block in call’

activesupport-7.0.4.3/lib/active_support/callbacks.rb:99:in `run_callbacks’

actionpack-7.0.4.3/lib/action_dispatch/middleware/callbacks.rb:26:in `call’

actionpack-7.0.4.3/lib/action_dispatch/middleware/debug_exceptions.rb:28:in `call’

actionpack-7.0.4.3/lib/action_dispatch/middleware/show_exceptions.rb:26:in `call’

logster-2.12.2/lib/logster/middleware/reporter.rb:43:in `call’

railties-7.0.4.3/lib/rails/rack/logger.rb:40:in `call_app’

railties-7.0.4.3/lib/rails/rack/logger.rb:27:in `call’

/var/www/discourse/config/initializers/100-quiet_logger.rb:20:in `call’

/var/www/discourse/config/initializers/100-silence_logger.rb:29:in `call’

actionpack-7.0.4.3/lib/action_dispatch/middleware/remote_ip.rb:93:in `call’

actionpack-7.0.4.3/lib/action_dispatch/middleware/request_id.rb:26:in `call’

/var/www/discourse/lib/middleware/enforce_hostname.rb:24:in `call’

rack-2.2.7/lib/rack/method_override.rb:24:in `call’

actionpack-7.0.4.3/lib/action_dispatch/middleware/executor.rb:14:in `call’

rack-2.2.7/lib/rack/sendfile.rb:110:in `call’

actionpack-7.0.4.3/lib/action_dispatch/middleware/host_authorization.rb:131:in `call’

/var/www/discourse/plugins/discourse-prometheus/lib/middleware/metrics.rb:14:in `call’

rack-mini-profiler-3.1.0/lib/mini_profiler.rb:260:in `call’

message_bus-4.3.2/lib/message_bus/rack/middleware.rb:60:in `call’

/var/www/discourse/lib/middleware/request_tracker.rb:228:in `call’

railties-7.0.4.3/lib/rails/engine.rb:530:in `call’

railties-7.0.4.3/lib/rails/railtie.rb:226:in `public_send’

railties-7.0.4.3/lib/rails/railtie.rb:226:in `method_missing’

rack-2.2.7/lib/rack/urlmap.rb:74:in `block in call’

rack-2.2.7/lib/rack/urlmap.rb:58:in `each’

rack-2.2.7/lib/rack/urlmap.rb:58:in `call’

unicorn-6.1.0/lib/unicorn/http_server.rb:634:in `process_client’

unicorn-6.1.0/lib/unicorn/http_server.rb:739:in `worker_loop’

unicorn-6.1.0/lib/unicorn/http_server.rb:547:in `spawn_missing_workers’

unicorn-6.1.0/lib/unicorn/http_server.rb:143:in `start’

unicorn-6.1.0/bin/unicorn:128:in `<top (required)>’

/var/www/discourse/vendor/bundle/ruby/3.2.0/bin/unicorn:25:in `load’

/var/www/discourse/vendor/bundle/ruby/3.2.0/bin/unicorn:25:in `’

2 Likes

I’ve split these off into their own topic as it seems there are a few reports. :+1: I am no closer to working out what the issue is though. :frowning:

4 Likes