Git pull needed?

(Dave Higgins) #1

A few places on meta and on the blog advise git pull before ./launcher rebuild app. I’ve never done git pull, only the latter, and my Discourse instance seems to update fine. What’s the value of git pull?

(Matt Palmer) #2

The git pull brings down new versions of the discourse_docker repo, which is the launcher program itself (and all its supporting materials). We do, from time to time, make useful improvements there, although it’s far less frequent (and critical) than updating the application itself.

(Felix Freiberger) #3

Also, @sam taught the launcher to update itself in March 2015:

So you only need to run git pull once if you’re still on an older version, a ./launcher rebuild app will be sufficient after that.

Retain launcher command past an image download?
(Jeff Atwood) #4

Is this still true @sam? Even our template reply still says git pull in it…

(Sam Saffron) #5

git pull is needed if you are on an old version of discourse-docker, that is why I always but it in with my instructions.

No idea if people are running 3 year old versions of discourse docker.

(Jeff Atwood) #6

Hmm I think we should drop it at this point, two lines is more better than three.