Github boxes should be truncated


I think the text in the github boxes should be truncated. It does not look beautiful when linking to a commit with a long description, see this example:

Option to not truncate GitHub/GitLab onebox
(Sam Saffron) #2

Sure, PR to onebox welcome GitHub - discourse/onebox: A gem for turning URLs into website previews

(Kane York) #3

Here’s a better idea: Only the first line of the commit should be in the big size and blue, the later lines should be non-bold and normal, and have proper linebreaks in them.

Would be more difficult to do, though.

(Sam Saffron) #4

We needs less imagineering here and more shipping :slight_smile:

(Kane York) #5

Yep, it’s entirely possible that what I described would be butt-ugly…


I am not that Ruby pro, but I will have a look at this. Maybe I am able to fix it. :blush:

Try this one [github_commit] Extract the first line of a commit as the title by rumpelsepp · Pull Request #257 · discourse/onebox · GitHub


merged, could be closed, @codinghorror

(Jeff Atwood) #8