Github boxes should be truncated


#1

I think the text in the github boxes should be truncated. It does not look beautiful when linking to a commit with a long description, see this example:

https://github.com/torvalds/linux/commit/45eaf45dfa4850df16bc2e8e7903d89021137f40


(Sam Saffron) #2

Sure, PR to onebox welcome GitHub - discourse/onebox: A gem for turning URLs into website previews


(Kane York) #3

Here’s a better idea: Only the first line of the commit should be in the big size and blue, the later lines should be non-bold and normal, and have proper linebreaks in them.

Would be more difficult to do, though.


(Sam Saffron) #4

We needs less imagineering here and more shipping :slight_smile:


(Kane York) #5

Yep, it’s entirely possible that what I described would be butt-ugly…


#6

I am not that Ruby pro, but I will have a look at this. Maybe I am able to fix it. :blush:

Try this one [github_commit] Extract the first line of a commit as the title by rumpelsepp · Pull Request #257 · discourse/onebox · GitHub


#7

https://github.com/discourse/onebox/pull/257

merged, could be closed, @codinghorror


(Jeff Atwood) #8