GitHub onebox wrongly adds extra empty lines after each code line in the emails

dmitry_fedyuk · 26 أبريل 2016، 12:12م

An original code (correct rendering):

lib/internal/Magento/Framework/DB/Transaction.php

720667e


      
          /**
           * Commit transaction for all resources
           *
           * @return $this
           */
          protected function _commitTransaction()
          {
              foreach ($this->_objects as $object) {
                  $object->getResource()->commit();
              }
              return $this;
          }

A email with the code (wrong rendering: extra empty lines are added, the screenshot is taken in the GMail web interface):

sam · 28 أبريل 2016، 12:56ص

Are you sure there are empty lines there and its not simply that the CSS is a bit off?

dmitry_fedyuk · 28 أبريل 2016، 11:44م

The line breaks between the <li> tags are preserved because the code is inside the <pre> tag.
Additionally, each line of code has a bottom padding of 10px:

dmitry_fedyuk · 19 يناير 2017، 8:42ص

Now it became even worse: the violet background now covers only a part of the code block:

sam · 21 يوليو 2022، 6:56ص

تم حله منذ فترة

الموضوع		الردود	مرات العرض
Code blocks in emails have empty newlines Support	3	514	21 يونيو 2022
GitHub onebox wrongly removes identation inside the curly braces Bug	5	1255	7 مارس 2019
Line breaks in code blocks don't work without a linebreak above Bug	8	1992	31 يوليو 2015
GitHub onebox does not skip leading tabs Feature	6	1172	20 أبريل 2016
Rendering of e-mail template adds unnecessary whitespace Feature	7	1150	26 مايو 2017

GitHub onebox wrongly adds extra empty lines after each code line in the emails

الموضوعات ذات الصلة