Github - There isn’t anything to compare

Using the compare from the OP (940eb28e…fc61a7c0) I see the same result. Adding one more character of the second commit hash (940eb28e…fc61a7c0d) I get the correct comparison.

My suspicion is that this is caused by commit hash ambiguity, i.e. there are two commits that both start with fc61a7c0 so it doesn’t know which one to use. I don’t see it in the commit history but it could be orphaned.

It looks like docker_manager uses git rev-parse --short to get the hashes for that URL. In theory that will produce unique hashes starting at 7 (by default) characters long and increasing in length as necessary to guarantee uniqueness. Orphaned commits are ignored when pulling though so what git believes to be unique on a Discourse instance might not be unique on GitHub.

This will be quite rare though and there have been commits since your post so the problem has probably already gone away if you check for updates again.

5 Likes