Something that has bugged me for a little while, but which I have not mentioned until now, is that the links provided on the upgrade screen don’t allow for easy comparison of the currently-installed commit vs the new-version commit.
I just realized the first link and my suggested link are essentially identical. Would this always been the case, even if I get behind by more than one version?
Yes, the first link is your current commit compared to the head of tests-passed, which is what your upgrade will be. Never fully understood what the second link is for myself…
The other version comparsion is comparing the tests passed label to the latest checkin at discourse/discourse, thus the only way that would be different is if someone just checked in something that causes the tests to fail.
Furthermore, the only way it would remain different is if the build was not fixed for an extended period of time, meaning more and more stuff was checked into latest and none of it fixed the build by getting the tests to pass. This is rare, but it does happen from time to time.
It is a valid comparison, in my opinion.
So there’s nothing to do here, I don’t think either of these requests are actionable? Shall I close this topic @abrambailey?
Oh I see what you’re saying. The links should be swapped, so the upgrade button is closer to the “exactly how many changes will I get and what will they be” link.
That’s kind of a different argument, but OK, sure.
Sure … @Osama when you do the ember upgrade can you take that? Also, the styling on the commit hashes is too strong should be lighter grey, plus… maybe we should try for friendlier names if available: v2.2.0.beta6 +100 and so on… not possible for all repos, but where it is … it would be very handy.
