GitHub diff stat link for commits results in 404 link

[rugk]

Here is a box:

Use promise instead of callback

STR

Click on the diff summary (+6-7 in this case) here…

What happens

404 error at https://github.com/rugk/mastodon-simplified-federation/commit/f8dedaa250ce2ea1734731a107cbe25b24f660e9/files

What should happen

Dunno. This is no PR, maybe this was made for PRs, where that link would make sense, but I don’t know where this should link to in case of commits…

The only thing I could imagine would be a direct link to the diff stat/summary on GitHub (if possible), i.e.:

Other

Possibly introduced by:

Github onebox does not point to individual commits in PR links

https://github.com/discourse/discourse/pull/4662/commits/706b4f6b9faf1f820a294e83f82b0b5a5dba0475 https://github.com/discourse/discourse/pull/4662/commits/706b4f6b9faf1f820a294e83f82b0b5a5dba0475 https://github.com/discourse/discourse/pull/4662 https://github.com/discourse/discourse/pull/4662 Both links generate the same onebox even though the first link is pointing to a particular commit in the PR.

[sam (Sam Saffron)]

@david maybe you can have a look at this?

[tshenry (Taylor)]

I think we might need to drop the /files from here, or pick a different location:

https://github.com/discourse/onebox/blob/master/templates/githubcommit.mustache#L25

[david (David Taylor)]

Yep, exactly @tshenry. I must have copy/pasted it from the PR onebox.

I’ll fix and bump onebox now