Google photos images not downloaded

(Jay Pfaffman) #1

It seems that Discourse doesn’t see that Google image links are images in order to know to download them locally.

I noticed this first on a multi-site instance, and then checked on try.

Here’s this url that renders beautifully into an image, but it never gets pulled down locally. I think it’s because the stupid Google doesn’t make those URLs end in .jpg the way God intended and there’s nothing that can be done, but I thought I’d ask anyway.

Google Photos

(Sam Saffron) #3

Interesting … what about flickr?

(Sam Saffron) #4

I think this is not specific to google, its more of an all onebox thing, @techAPJ any idea why this is happening.

Also … behold my ninja hamster above, so cute, yet so dangerous.

(Jeff Atwood) #6

Kind of a scope creep, let’s focus on other things for now. It’s been this way forever.

(Sam Saffron) #7

Yeah I remember this popping up before, I am just a bit surprised cause I thought @vinothkannans fixed this a while back.

(Jeff Atwood) #8

Oh aha maybe @vinothkannans can take a peek next week if he already worked on it before.

(Vinoth Kannan) #10

We already downloading onebox images. The issue here is “Google Photos” not using file extension in the image URLs. So we are unable to fetch it from the post content. Anyway we can achieve it by adding a special case for Google. Added to my list.

Why it’s not working :thinking:. It have valid image URL ( inside onebox html.

(Sam Saffron) #11

Why do we need this though? Should we not just try to download everything that is <img src="">, it will come back with a mime type.

(Vinoth Kannan) #12

Yes, good question. We should download everything in img src. I will investigate further :+1:

(Vinoth Kannan) #13

I’ve fixed it here.

(Vinoth Kannan) closed #14

This topic was automatically closed after 5 days. New replies are no longer allowed.