"Granted By" on badges not displaying the staff name

[Richie (Richie Rich)]

Hello everyone.

Discourse version 3.2.0.beta2-dev (1a70817962)

When manually issuing badges to our members via the admin pages, the “Granted By” staff name is not being displayed:

Possibly related to: Grant badge reason not added to the granted badge

[Don]

Hello

If I now it correctly it only record here the system_users. If a staff grant a badge to a user than it place to the Staff Action Logs. /admin/logs/staff_action_logs

However I think it would be a great feature to add this to the manually granted badges by staff.

[Arkshine]

It shows any records created by staff as well. You’re right for the log.

From what I see, the template is ready to display the granter name, but the code expects the payload (creation and listing) to include a list of users so the name can be figured out based on the granter ID. I think it has never been implemented.

[Don]

This commit is probably relevant I think Unfortunately the meta topic discussion about it is not available anymore.

FIX: use UserBadgeSerializer::UserSerializer for user_badge.granted_by

[Richie (Richie Rich)]

@Don

Unfortunately the meta topic discussion about it is not available anymore.

FIX: use UserBadgeSerializer::UserSerializer for user_badge.granted_by by xrav3nz · Pull Request #6266 · discourse/discourse · GitHub

Is it not this one?

Trouble accessing preferences after upgrade to Discourse 2.1.0.beta4

I just updated a site and now I’m not able to access /my/preferences/account. I get Server Error while trying to load /user-badges/jayp.json Error code: 504 Gateway Time-out I tried safe mode, and removed the only non-standard plugin (retort). Though other users do seem to be able to access their preferences. Many are complaining about group-based theme modifications not working, so it seems that there might be some problem with groups. Other pages seem to load fine, however. I don’t see anyt…

[JammyDodger]

I raised it from the dead after I read Don’s comment this morning.

[Richie (Richie Rich)]

Ahhhh, I thought I’d gained extra special privileges or something

[kelv (Kelvin T)]

Thanks for reporting this, fixed in FIX: display and link to correct grant_by users for granted badges by tyb-talks · Pull Request #24021 · discourse/discourse · GitHub

[Richie (Richie Rich)]

Brilliant, thanks @kelv

[Richie (Richie Rich)]

@kelv going by the FIX commit message, was this actually a bug then?

Rather than just something that wasn’t implemented?

[kelv (Kelvin T)]

I was never able to find a breaking commit so I’m unsure if it was a planned feature that was never implemented or a bug Either way, I figured that the UI seemed to have the explicit intention to have this in place (going by the Granted By column header) so I opted to go with FIX.

[Richie (Richie Rich)]

Well, the fix works great, thanks again