Guest Gate (Sign Up Popup Plugin)

plugin
12

Hi!
The plugin has incorrect (outdated?) modal.hbs template:

      <div class="modal-inner-container">
        <div class="modal-header">
          <a class="close" {{action "closeModal"}}>{{fa-icon "times"}}</a>
          <h3>{{title}}</h3>
          <div class="clearfix"></div>
        </div>

The .close anchor should be wrapped in div with modal-close class.

It has several consequence:
https://meta.discourse.org/t/dialog-close-button-design/60727/
https://meta.discourse.org/t/dialog-and-esc-handling/60725

PR: https://github.com/jgujgu/discourse-guest-gate/pull/3

6 Likes