Handle deleted topics better in embed

bug
1

We’re on the cusp of rolling out the embedded comments on our blog and I noticed a few oddities.

  1. if the embed url points to a topic that exists but is deleted, it shows -1 replies

  2. when starting discussion on a deleted topic you visit that topic and it still shows as deleted. I would expect it to reopen that topic.

2

Anything we can do about the -1 issue @eviltrout? Low priority though.

3

The -1 issue has been fixed in master:

https://github.com/discourse/discourse/commit/5056de1d8a88ae06c56cdf20a6d987a1973347e3

I don’t think re-opening the topic as explained in 2 is safe. I feel like it could give the user following through too much power. It’s probably better if they get the “missing / not proper access” page.

3 Likes