I have my file types for uploads set to defaults of just images but I still see the upload button rather than the image button, is there anywhere else besides this setting that would trigger this?
2 Likes
Yeah, we do appear to have regressed here. The modal is still correct (text is the image-only strings, icon in button is picture) but the icon in the composer is wrong.
2 Likes
To clarify for @joffreyjaffeux, if the allowed filetypes are all default (.jpg, .gif, .png) then the glyph should be of an image, because those are the only types allowed. Once you add additional filetypes the glyph changes to generic upload.
5 Likes
Good catch David! Thanks.
This should be fixed by:
https://github.com/discourse/discourse/commit/4b604b1e68f51650ba78b1853b99a72f6e4c9894
I created a common implementation to decide which icon to display which should avoid any difference in the future.
9 Likes