Mainly, I need to clean up the code and make it more in-line with Discourse. It’s a bit sloppy at the moment, since I was actively learning how to make a theme component here
I’m also planning on adding a way to change the slider direction from the composer- right now, the direction is whatever has been set in the admin settings, I’d like to make that user controllable. (EDIT: this has been added!)
I’ve added the ability for the user to choose a vertical or horizontal slider, using a data-direction-horizontal or data-direction-vertical attribute. The default setting chosen in the admin settings will be used if the user doesn’t specify a direction
This update is available now on GitHub or from the Discourse admin panel, if you’ve installed the theme component
It’s hard to say what’s causing this, I can’t replicate it on my end Of those errors, only the first one could be from this component, as I’m not using a tooltipContainer or a ResizeObserver loop, but again, I’m not really sure. Have you updated to the most recent version? I made some changes yesterday that might fix this
Thanks Joseph, I am on the latest version. It’s weird, I can’t get this message to display again and I don’t see any issues, so maybe it was a fluke?
Another thing, the icon does not want to change. I have, of course, added it to the svg icon subset. I have also tried different icons that are already working on my site and it just doesn’t change from the bolt. I’m trying to change it to arrows-alt-h
In my forum we swapped to en_GB locale, so when I mouse over I get:
instead of the alt/flavour text from the component settings:
Can't select text
The plugin seems to steal all cursor mouse-down events and prevents me from selecting any text on the page for copy/paste/quote, etc. This isn’t a problem on meta.discourse…Happy to provide more details about my config/theme (mostly Sam’s simple theme with a few extra components like gallery and gifs) it went away…I love technology.
Hmm… this is strange, I tested it on Firefox with no issues. I’ll see if I can reproduce this. Gotta love random bugs the library I’m using doesn’t have any issues on the GitHub repo for Firefox, open or closed, so that makes bug fixing even harder.
Locales- I’m not sure what the process is for providing locale files, I can add a en.GB since I speak that language but that’s about the extent of my expertise. Do any other theme component authors know how locale file translations are supposed to work? Should I just run the text through Google Translate?
@Frully I’ve fixed the Firefox problem- this should now work on every browser (I’ve tested Chrome, Firefox, Safari, and mobile versions with no issues). If you update this, it’ll work for your Firefox users
I hadn’t thought about that issue. Thanks for pointing it out @Stephane_Roy!
The issue is that both theme components uses the same translation variables. Other TC may have the same issue… The fix is to update/change the name of button_text and add_images_prompt in the places below. I will update Masonry Image Gallery as well.