Imgur embeds broken


#1

Imgur galleries used to show up with a nice onebox preview of the gallery, but this broke recently and just a link is shown. e.g.

I viewed this topic on Meta on May 26th and the preview was working, now it is not. The preview in the first post will show up if you try replying to that topic (or this topic), and pasting any imgur galley URL into the edit box, but you won’t see a preview for the URL you just pasted. The preview won’t be there if you refresh the page.

I saw the same behavior on a forum hosted at DiscourseHosting.com also on May 26th, when they were running 1.2. The behavior is still there this week with 1.3.


TIL: Discourse can embed imgur albums and galleries
(Jeff Atwood) #2

It’s because Imgur changed it on their end.


#3

Hmm, that doesn’t explain why it was working here but not at my DiscourseHosting forum at the same time (on May 26th). Is this broken until Imgur changes something back, or until Discourse releases a fix?


(Jeff Atwood) #4

See @eviltrout’s answer here:


(Dean Taylor) #5

Here’s a little freaky magic for ya - you can get them working by attempting to reply with any imgur gallery URL.

obviously not a fix, nor real magic - sorry


(anonymous234) #6

I was about to submit this bug again but I found this.

However, as the last post shows, sometimes embeds spontaneously appear. So regardless of what imgur is doing, Discourse must be doing something weird as well.

For example, when I click edit in one of my posts, the gallery appears

Similarly, when I paste a gallery link on the editor, it appears, but disappears after a carriage return.


(Sam Saffron) #7

Is this a timing issue in the composer, does typing a bit more kick it out of crazy mode ?


(anonymous234) #8

Not really, in fact right now I can’t even get it to appear at all.


(Kane York) #9

@sam imgur embeds are using a <script> tag which gets excised from the final post by the html-sanitizer-bundle, but if you edit the post the script is loaded. we need a custom onebox for imgur albums.


(Jeff Atwood) #10

We should do this as Imgur is a customer. Can you add it to your list @techapj?


(Kane York) #11

To be fair, it would’ve gotten done anyways, eventually. :stuck_out_tongue:


(Arpit Jalan) #12

Okay, I just added custom Imgur onebox engine. Here are the features:

  • When Imgur image link is provided, it extracts the image and shows that, clicking on image will take you to original imgur link.

http://imgur.com/gallery/uN1SCcs

  • When Imgur gif link is provided, it extracts the mp4 video source and shows the HTML5 video player (with controls/autoplay/loop).

https://imgur.com/gallery/WsOzfY2

  • When Imgur gallery link is provided, it extracts the first image from the gallery and shows that, clicking on image will take you to original imgur gallery link.

https://github.com/discourse/onebox/commit/9526fb1fa79aac912a920439b97058ccb7d4c438

(cc @eviltrout)


Imgur gallery should have some indication that it's an album
(Arpit Jalan) #13

(Arpit Jalan) #14

A post was split to a new topic: Imgur album should have some indication that it’s an album