Improved Bookmarks with Reminders

Yes exactly, just remove it from the list of commands on the post if you really want to be rid of bookmark. It’s kind of a useless feature as it existed before anyway… literally the only thing it was good for is cross-browser cross OS “bookmarks” which is such a narrow use case.

7 Likes

Ok, so following the “theme component” route is the right way to get this done? I’m not going to try to convince y’all to do this… but I hope it’s okay to ask for some guidance on how I can accomplish this for my setup.

Noted.

1 Like

It was a productive day today. The following PRs were merged, and all except the last is now live on Meta:



And FIX: Do not save bookmark if close (X) on modal is clicked by martin-brennan · Pull Request #9541 · discourse/discourse · GitHub should be merged soon. I also have a PR up to change the /bookmarks-with-reminders URL back to /bookmarks, hoping to merge that tomorrow FIX: Change bookmarks-with-reminders URL back to bookmarks for user activity by martin-brennan · Pull Request #9566 · discourse/discourse · GitHub.

The “Topic user bookmarked column logic was not correct” fix should be live on Meta in the next couple of hours. Later this week we will be cutting another beta release for all of these fixes.

18 Likes

Another update – both of these PRs are now merged and there are no outstanding bugs. I am now just working on a final PR to rename variables etc. like bookmarkWithReminder back to bookmark.


12 Likes

I’ve implemented single click, no dialogue, bookmarking from the Topic List in the Topic List Previews plugin (which still allows you to use rich bookmarking from Topics)

It might not be stable for a few days as I try to keep pace with all the core changes but yesterday it was working!

5 Likes

That’s awesome, thank you!

2 Likes

The final PR is now merged. We should have a new beta out in the next day or so. There are now no outstanding issues with the new bookmarks :star2:.

14 Likes

Excited to use with the new release. Just 1 question.

  • Do the bookmark reminder notification send email (if the user is not logged in)?
1 Like

You will get a count of unread high priority notifications in your user digest email (which bookmark reminders contribute to) but apart from that no, you receive no reminder via email.

You can also sync bookmarks with your calendar Sync Bookmark Reminders with your favorite Calendar app.

4 Likes

I have just merged in another change that will be live on Meta within a couple of hours. There is now a hidden option in the bookmark modal that will delete the bookmark once the reminder has been sent. We remember which option you choose in local storage, so this behaviour will be the same for each bookmark you create.

image

9 Likes

The idea that people would use browser bookmarks amuses me, so I’m very glad that Discourse still has a bookmarks feature. I frequently bookmark posts here, but it would never occur to me to add a bookmark to my browser. Guess I’m weird.

3 Likes

I’ve added another PR now that fixes the issue here Domain.com/bookmarks is showing domain.com/u/user/activity/bookmarks-with-reminders, and also adds the bookmarked post user avatar to the bookmarks list. It will be merged soon:

cc @Ellibereth , I know in an earlier post you mentioned you wanted to see the avatars, and @exetico for the URL change.

11 Likes

I’d be nice if the “What is this bookmark for” field’s information was utilized more. Right now the only way to see that information is from the full bookmark list in your profile or opening the bookmark itself. I think it would be more useful if it was used in the bookmark list from the dropdown menu and/or if it was included in the reminder notification.

4 Likes

Reminders don’t have any extra info so how do you see that working? Add an entirely new area of functionality, just for this?

3 Likes

Rather, I wonder if the text in that field (if set) should replace the topic title in the notification. Just a thought.

7 Likes

I somewhat agree with you. This may not be very obvious, but you can see the “what is this bookmark for” information when you hover over the reminder notification. We already have the information when we notify, but we didn’t want to create a different notification format just for this feature.

9 Likes

I didn’t realize that. Thanks for the tip!

6 Likes

The “What is this bookmark for?” input has the id bookmark-name and the name name, so Chrome is trying to autocomplete it with my actual name. Can you update this input to turn autocomplete off? I believe you guys are mostly using autocomplete="discourse" these days.

9 Likes

Ah Chrome Autocomplete, my arch nemesis. Thanks for reporting I’ll try to get an autocomplete fix out for this today.

13 Likes

@seanblue I did a fix for this, all I had to do was change the name attribute to bookmark-name and the autocomplete stopped:

7 Likes