Ahah! I think I’ve found the issue
main ← dev-improve-topics-bulk-action-specs
The `silent` option for bulk category changes was not being respected
when `crea… te_revision_on_bulk_topic_moves` was enabled. This caused
users watching the destination category to receive notifications even
when the "Perform this action silently" checkbox was checked.
The bug was introduced in commit 7a099ebb6a which added `silent: @silent`
to the `track_topic_field(:category_id)` block. However, since blocks
capture `self` at definition time (the class, not the instance), `@silent`
was always nil in that context.
The fix passes the `silent` value through the `TopicChanges` object which
is already available to the block as `tc`.
Also extends test coverage to verify both topic watchers and category
watchers are properly silenced in both code paths.
Ref - meta/t/390993
The @silent option wasn’t propagating properly which caused users watching the destination category to receive notifications even when the “Perform this action silently” checkbox was checked.
6 лайков
