February 15, 2018, 5:37am
I first noticed this from the private messages I received from the “Save Searches” plugin yesterday:
I thought this was simply flaky but the same happened with today’s message.
Internal links seem to onebox fine when linking in a topic/post:
Yet it failed to onebox when I just tried to link it in a private message:
The external link on the bottom worked, in contrast.
February 15, 2018, 5:15pm
IIRC this may have to do with a fix to a leaking problem. i.e. the public topic displayed a link to the message. Clicking the link gave the “oops or private” page, but the title of the message topic and the fact one existed was exposed. eg.
Is this guy a first class numpty or what?
February 16, 2018, 6:24pm
Follow up question: has there been a deliberate change in how a onebox to a internal link that does not belong to the current topic renders?
Linking a post in the current topic renders as “quote”:
Linking a post that does not belong to the current post
used to render as the following:
But currently, also as a quote: (a possible
Hmm. When I did this last week, I did the deactive, then activate thing. Adding “approved=true” is a good idea. I’m not sure that it matters unless the site requires approval, but I don’t see how it could hurt.
Here’s my solution:
February 16, 2018, 7:01pm
Yeah, since we removed the
source_topic_id parameter, there’s no way for the server to know if we’re in the same topic or not anymore…
February 16, 2018, 11:27pm
Oh we should change this so we always use the off topic style if we must, but we can also pass in topic id with category id
February 20, 2018, 12:06am
Are you saying this will be corrected or there’ll be a new way to link? Linking between topics is something we find very useful.
In fact the only thing I wish it did do that it doesn’t is to display the images in the linked post too.
This is something
@zogstrip is actively working on; he’ll update in a bit.
February 20, 2018, 2:25am
February 20, 2018, 3:13pm
A post in the current topic:
A post from another topic:
Discourse ships with 3 different global rate limits that can be configured by site admins.
Global per-ip rate limits
These limits apply to every unique IP address that hits the Discourse application. (files that are served directly from the filesystem or the CDN are excluded)
By default this rate limit is enabled, you may disable it or set it to a reporting mode.
DISCOURSE_MAX_REQS_PER_IP_MODE : default block, this rate limit applies out of the box. (other options are warn, warn+block, and n…
tada Thanks @zogstrip for following through with the issue!
What I see in composer preview:
What I see in the post:
Why do I feel like we have gone down some kind of rabbit hole…
February 21, 2018, 4:29pm