When I run the wizard (I updated in the past several hours) and get to the icons page (/wizard/steps/icons), it won’t let me click next, presumably because I have not uploaded any icons.
Is this what’s intended? It doesn’t seem very nice to force people to come up with artwork. 
Hmm no that would be a regression @joffreyjaffeux
@tgxworld can you have a look please?
The stacktrace shows:
NoMethodError in StepsController#update undefined method `encoding’
which happens in app/models/upload.rb:185
The params sent to the controller are:
<ActionController::Parameters {"fields"=>{"favicon"=>{"id"=>"101286", "user_id"=>"2770", "original_filename"=>"logo-small.png", "filesize"=>"13844", "width"=>"350", "height"=>"349", "url"=>"//assets-meta-cdck-prod-meta.s3.dualstack.us-west-1.amazonaws.com/original/3X/b/3/b33be9538df3547fcf9d1a51a4637d77392ac6f9.png", "created_at"=>"2018-07-18T04:13:01.619Z", "updated_at"=>"2018-07-18T04:13:01.684Z", "sha1"=>"b33be9538df3547fcf9d1a51a4637d77392ac6f9", "origin"=>"", "retain_hours"=>"", "extension"=>"png", "thumbnail_width"=>"350", "thumbnail_height"=>"349"}, "apple_touch_icon"=>{"id"=>"76914", "user_id"=>"3", "original_filename"=>"meta-logo-small.png", "filesize"=>"4614", "width"=>"350", "height"=>"349", "url"=>"//assets-meta-cdck-prod-meta.s3.dualstack.us-west-1.amazonaws.com/original/3X/a/c/ac166452701ce353fa6c8865e99879e8cacfb960.png", "created_at"=>"2017-08-16T14:25:06.738Z", "updated_at"=>"2017-08-16T14:25:07.250Z", "sha1"=>"ac166452701ce353fa6c8865e99879e8cacfb960", "origin"=>"", "retain_hours"=>"", "extension"=>"png", "thumbnail_width"=>"350", "thumbnail_height"=>"349"}}, "controller"=>"steps", "action"=>"update", "id"=>"icons"} permitted: false>
Which is kind of unexpected given I don’t have anything set:
If you still think it’s not related to uploads let me know, I will dig deeper in my recent changes.
Thanks for reporting @pfaffman
This is fixed in
https://github.com/discourse/discourse/commit/596e09aaf9c45abe3758ebaea6787e34844bf365
This topic was automatically closed after 2 days. New replies are no longer allowed.
