Uploading favicon.ico

[Samuel_Walker]

Attempting to upload an icon.ico hangs the setup page button to “uploading…” without any indication that it isn’t supported.

Replicate with https://thebobsgamingnetwork.net/favicon.ico and a fresh install of discourse.

[dax (Daniela)]

Yeah, the problem is that ico is not among the extensions authorized at the first start (it can be added later). We should add the authorized extensions to the wizard

[codinghorror (Jeff Atwood)]

ICO is an obsolete format for the web – I strongly recommend using simple PNG or JPG instead.

[zogstrip]

@dax

We should add the authorized extensions to the wizard

I think it’s better to show a proper error message since ICO are deprecated…

[codinghorror (Jeff Atwood)]

Can we give this to @techAPJ? All we need to do is show an educational panel if someone tries to upload an obsolete ICO file.

[techAPJ (Arpit Jalan)]

We will now show proper error message (received from server side) when upload fails in wizard and re-enable the upload button. This issue was applicable on “Logos” step too.

FIX: display error message when upload fails in wizard

Demo:

I also updated the help text on “Icons” step to indicate recommended image extensions.