Issue with x.com previews

MarcP · May 18, 2024, 4:48pm

Everything seems fine on opengraph.xyz - not sure if this is on Discourse end?

But:

Posting old twitter.com link does work.

https://twitter.com/X/status/1791399086182031741

Firepup650 · May 18, 2024, 4:52pm

If I had to guess, I’d say twitter.com had a special oneboxing rule, and that rule now needs to be copied to x.com.

Arkshine · May 18, 2024, 9:05pm

Indeed.

github.com/discourse/discourse

lib/onebox/engine/twitter_status_onebox.rb

main


      
          
          module Onebox
            module Engine
              class TwitterStatusOnebox
                include Engine
                include LayoutSupport
                include HTML
                include ActionView::Helpers::NumberHelper
          
                matches_domain("twitter.com", "www.twitter.com", "mobile.twitter.com", "x.com", "www.x.com")
                always_https
          
                def self.matches_path(path)
                  path.match?(%r{^/.+?/status(es)?/\d+(/(video|photo)/\d?)?(/?\?.*)?/?$})
                end
          
                def to_html(ignore_errors = false)
                  return "" if raw.blank?
          
                  unless ignore_errors
                    verified_data

jancernik · May 23, 2024, 2:34pm

Thanks for the report! We merged a fix for this today
https://github.com/discourse/discourse/commit/1ed1a1f96a98c242e693d0aef06a4d614528e4fa

JammyDodger · May 26, 2024, 2:58pm

This topic was automatically closed after 3 days. New replies are no longer allowed.

Topic		Replies	Views
Impossible to prevent x.com oneboxes (and they're broken) Bug onebox	1	105	March 25, 2026
Issue about X preview Bug	11	375	March 11, 2025
Twitter oneboxes are no longer working on my install Support	5	989	June 3, 2023
Twitter Mobile OneBox missing images due to lack of API keys Support	6	1200	February 4, 2020
Twitter embeds have broken Support	27	3790	July 8, 2020

Issue with x.com previews

Related topics