Lefthook のサポート

Falco · 2019 年 7 月 2 日午後 10:20

今日初めて使いましたが、マシンでのセットアップが一切不要だったのが素晴らしいです。

プルリクエストをありがとうございます！

ここにコンテキストがあります：

github.com/discourse/discourse

DEV: Replace Overcommit with Lefthook (#7826)

master ← Arkweid:replace-overcommit-with-lefthook

merged 09:29AM - 02 Jul 19 UTC

Arkweid

+59 -52

Overcommit uses prebuilt hooks and require global installation. To avoid this i…ssues replace it with [Lefthook](https://github.com/Arkweid/lefthook). Lefthook will be installed with npm packages. New contributors will have fully consistent git hooks. Goals: - **Strict workflow**. Avoid situations when newcomers pushed PR without checks with rubocop or eslint. And members should [recommend](https://github.com/discourse/discourse/pull/7192#issuecomment-473973502) to install overcommit. - **Flexibility**. You free to combine basic operations. - **Сlarification**. Overcommit provide prebuilt hooks. So its hard to understend what is going on without inspecting overcommit repository. - **20% Faster**. Well, it not a big issue in development environment, but a like faster instruments :) - **Twice speed up for CI lints**. With Lefthook we can run lints on CI in paralel mode. You can check [example here](https://travis-ci.org/discourse/discourse/jobs/551862476#L956). Example output for this commit: ![PR example](https://i.gyazo.com/1eb2d11850b1a826981bec7375527501.png "PR example") Example output for CI lints: ![PR example](https://i.gyazo.com/c5e2c92383437d3617bc138e28e74a01.png "PR example") Don't forget to remove preinstalled hooks from you repo `overcommit --uninstall` if you want to test it action. So what do you think about. Is it worth?

トピック		返信	表示
Automatically lint and format code before commits Developer Guides how-to , code	0	1564	2019 年 11 月 8 日
Debugging linting on Discourse Development	6	58	2024 年 7 月 25 日
Linting consistency Development	9	241	2025 年 12 月 2 日
Code linting and formatting with prettier Development	6	2579	2018 年 7 月 24 日
Webhooks feedback Development	33	11089	2017 年 3 月 21 日

Lefthook のサポート

関連トピック