Links improperly escaped

Our platform uses links that contain #! in the address, and recently it seems like Discourse is improperly escaping those links when displayed. Glitch freezes when trying to work on projects - Glitch Help - Glitch Support is an example post, the top link there in edit view is https://glitch.com/edit/#!/equinox-watch but the boxed link is https://glitch.com/edit/#%21%2Fequinox-watch, which ends up failing.

This seems like relatively new behavior. I suppose blacklisting our domain in OneBox might help, but I’m curious if something changed or if there’s any other mechanism to prevent this.

4 Likes

This sounds like same as Evernote oneboxes have extra %25 for each % in URL

3 Likes

The presentation is a little different, but it does indeed seem like the same root cause, thanks!

2 Likes

Fixed via:

https://github.com/discourse/onebox/commit/7bfbc3d7471b20ea5210fe5d1fe56b9e945bc29d

The fix will be deployed on your instance soon. Thanks for reporting this issue @cori :+1:

6 Likes