Locations Plugin

Plugin
980

What version of discourse you’re currently on?

981

I believe many people have migrated to the new Locations fact tables with no issues, so this is something peculiar to your instance.

As you can see from the code, I’ve tried to capture safely many cases where the data is bad (and ignore them), but might have missed a scenario and there is some kind of illegal json value.

Can you please either delete that Topics Custom Field (TopicCustomField) or fix its value, then retry.

There’s probably no point in keeping it because it’s likely an illegal value.

If there are not many Topics with locations, you can browse through them with this on the rails console:

TopicCustomField.where(name: "location").all

You can still access that custom field without the plugin installed.

Let me know what you find.

If this can be confirmed, I might improve the script.

I’m not aware of another report of this issue on this plugin.

2 Likes
982

I think that was a hangover from the posts being split from another topic before Locations was identified as the issue.

2 Likes
983

I was from 3.2.0 beta2, upgrading to version 3.2.0 beta4-dev.

using branch test-passed.

I used too many topics with location, so don’t really dare to delete them.

Hope the next version of rebuild is OK for this plugin.

984

I’m afraid you are going to have to do some investigation or it will likely fail again.

Please read my post above carefully.

985

I’ve just merged this big update that supports Zeitwerk properly and adds Ember 5 support:

Let me know if there are any issues.

3 Likes
986

@renato has kindly provided this awesome PR to add User Cards to User Map marker clicks!

Love it! :rocket: Thanks @renato !

@jimkleiber

9 Likes
987

Woohoo! I’m very excited to see this PR and grateful to @renato and @merefield for making it happen and @merefield for notifying me of it.

I just tested it out on one of my instances and I think I noticed a bug: when the map is fullscreen, the clicks don’t seem to show the card or navigate to the user profile.

Otherwise, I really like it, thank you :pray:t2:

3 Likes
988

good catch! @renato do you want to have a look at that scenario and perhaps add unit tests to the fix? (then we wouldn’t have missed it).

(weirdly it works on my android phone btw, but not desktop Edge nor Firefox).

2 Likes
989

To be honest I didn’t even notice we had this full-screen view :smile:

It looks like the user card is opening, but behind the map when it’s fixed with a higher z-index:

The user card uses float-kit’s z-index:

3 Likes
990

Yes! And explains why there’s no issue on mobile!

1 Like
991

That’s a very nice feature.

One small problem (being picky!)…if you click on an avatar near the right hand edge of the map the user card falls off the edge of the screen. The same happens with avatars near the bottom of the map, with the user card falling off the bottom of the screen. If the avatar is very close to the bottom it’s moved up to be more visible, but if you move the avatar a bit further away from the bottom it’s placed lower down so some of the card can’t be seen. Scroll bars can be used to view the card but I think it would be better if the card was positioned fully on the screen.

2 Likes
992

I’ll take a look when I get a chance, but I can also reproduce the card overflowing to the bottom on core if the avatar from a post stream is in a specific area:

overflowing bottom
overflowing bottom1420×664 142 KB

I couldn’t reproduce the card overflowing to the right, though.

The user avatars are in a position: absolute container to display the map and it may affect float-kits boundary detection strategy.

2 Likes
993

Thanks for the update Robert :tada: Works really great on Ember 5.
I’ve only noticed one issue but it maybe not related with this update. When the user remove the location from settings then it will still appear the empty location on the /u/username user page.

Screenshot 2023-12-20 at 10.30.12

Thanks :slightly_smiling_face:

2 Likes
994

Oh thanks for the report, I’ll take a look.

2 Likes
995

This is an example of the card overflowing to the right…

image
image541×586 104 KB

3 Likes
996

Hello just updated to the latest version.
It’s OK :+1:

The function “open user card on map avatar click” is fabulous: very practical for accessing a user’s information (their answers to questions for example) and elegant at the same time :heart_eyes:

  • Would it be possible for the map area to use all the available space?

  • Could be a bug: in full screen the map is partially refreshed at the edges…

Users map :

1 Like
997

A big THANK YOU from France for this dark theme.

The map now fits much better with the Starwars theme.

Would these 2 improvements be possible:

  • Makes the search box more readable. By changing its background or the color of the font?

  • Being able to choose on which criteria the search is carried out by default?
    On the user map the speudo would be more relevant.

Events map:

https://forums.ffjdr.org/c/e-irl/14/l/map

  • And also with this link : “Sorry, we were unable to generate a preview for this web page, because the web server returned an error code of 500. Instead of a preview, only a link will appear in your post”
1 Like
998

It’s a known issue.

I’m afraid I’m stretched across a lot of projects so I cant provide a resolution estimate.

1 Like
999

Perhaps adding ‘Search’ as placeholder text would also help?

1 Like