Malformed bullet causes emailed in topic to be incorrectly truncated

[tobiaseigen]

I know that a line with two dashes truncates everything below it.

-- 

But it turns out that a line with a single dash immediately followed by text (no space) will also truncate everything below it. See screenshots.

[codinghorror (Jeff Atwood)]

Well, that’s a malformed list in general… looks like an interaction between malformed list and GitHub’s email library detecting it as a signature, maybe?

[tobiaseigen]

Yeah, that sounds right.

It’s a drag that the parser is so unforgiving! Why a dash with no space and a word would be interpreted as a signature is beyond me.

[sam (Sam Saffron)]

It’s a legit bug, perhaps @techAPJ can have a look.

[riking (Kane York)]

@tobiaseigen

Why a dash with no space and a word would be interpreted as a signature is beyond me.

thanks

-Bobby McSignature

[tobiaseigen]

Hah. Smart guy. You are right. But I never do this and if I did would want it included in my message. I was referring to the automated sig that gets skipped with the preceeding two dashes.

[techAPJ (Arpit Jalan)]

Fixed via:

Better email reply parsing

There are many open bugs on meta related to incorrect email reply parsing and I have been looking into them since past few days. Almost everytime the fix is to correct/modify something in GitHub’s email_reply_parser library. The GitHub’s email_reply_parser library is now abandoned. The last commit was over a year ago, and there are many open issues / pull requests. I propose that we include the email_reply_parser in core Discourse email library so that we can customize it as per our requireme…