Media player stops playing when you scroll through a topic/thread. Didn't used to do this

(Bryan Holst) #1

As the title mentions, on my site, if there is a thread with audio uploaded, the built-in player will stop playing if you scroll beyond a certain number of replies. This is a new problem for us. It used to work fine.
I realize this may seem like a bit of a petty thing, but it’s actually extremely annoying given the nature of our community (audio recording/mixing forum).

To see an example of what is going on, just visit thread and start the audio on the top of the thread and then start going through the replies. At about the 11th reply down from the top, the audio will stop. Also, this is not an isolated problem. Happens on other topics, browsers, devices. As I mentioned, this was not a problem before (maybe the latest update a couple days ago?)

(Jeff Atwood) #2

Audio from what source? YouTube? Posts get unloaded as they scroll off. I believe YT has a special exception for this that @eviltrout put in a while ago.

(Bryan Holst) #3

Uploaded mp3’s are the source.
I haven’t tried embedded players from other sites yet (youtube, etc). That’s not as big of a deal to us anyway :wink:

It’s the built-in player for mp3’s that are more critical for us.

(Rafael dos Santos Silva) #4

Looks like cloak is only prevented on YouTube videos and on polls.

I believe we would need to listed to play/pause events to handle this properly.

(Bryan Holst) #5

cloak? I’m not familiar I guess :confused:

(Bryan Holst) #6

Just a quick note…

It appears that the problem is related to the most recent update. I installed another instance and restored a backup and didn’t experience the problem until I updated to the latest version.

(Jeff Atwood) #7

@eviltrout can have a look in a day or two

(Bryan Holst) #8

Thank you! I sure appreciate how responsive you guys are!!!

(Robin Ward) #9

This commit watches to see if an audio clip is played, and if so prevents it from being cloaked:

(Bryan Holst) #10

Is this a plugin that I need to install? Just double-checking. I’m still learning!

(Robin Ward) #11

Nope, that commit is in core. As soon as it builds, you should be able to update your Discourse install to use it.

(Bryan Holst) #12

So just to clarify, this will be in the next update? (sorry for the newbie questions)

(Robin Ward) #13

If you are running the tests-passed branch which is currently the default, it should be available now in your /admin/upgrade interface. If you’re running our beta branch it will take a little longer, perhaps in early 2017.

(Robin Ward) #14