Menu toggle for different reply modes

[joffreyjaffeux]

@david concerning a bug mentioned by @awesomerobot in whispers:

I linked it to the presence plugin which is I think not expecting we could create a new topic when we are browsing a topic. And will then subscribe to a null channel to messageBus in this case here : https://github.com/discourse/discourse/blob/master/plugins/discourse-presence/assets/javascripts/discourse/components/composer-presence-display.js.es6#L79

I think we shouldn’t try to subscribe to anything if action is not reply or edit. What do you think ?

[david (David Taylor)]

@joffreyjaffeux

I think we shouldn’t try to subscribe to anything if action is not reply or edit. What do you think ?

That sounds reasonable, there’s no need for any presence features on new topics.

The code has changed a lot since I wrote it, so I couldn’t say offhand where that change would need to be made. Longer term it would definitely be good to move a lot of this presence logic into message-bus as @sam mentioned a while ago

@sam

The big thing here is around adding “native” presence support for message bus.

At the moment there is a fiddly 50-100 lines of code you need to add to create a “presence” channel, the plan is just to have this native so we don’t need to carry all this luggage around.

[codinghorror (Jeff Atwood)]

@awesomerobot

would anyone be opposed to making this stand out slightly more as a button?

I think it should be quite subtle, so I prefer the current design. This is an extreme power user feature, not something we want to call a lot of extra attention to.

[joffreyjaffeux]

I just pushed a commit which should largely improve the situation. Let me know what you think @sam

[sam (Sam Saffron)]

Looks so much better!

[gerhard (Gerhard Schlager)]

“Toggle whisper” is missing in the dropdown when I click the topic’s reply button. It’s only visible after clicking a post’s reply button. Is that intentional?

[joffreyjaffeux]

Should be fixed thanks!

[featheredtoast (Jeff Wong)]

Love the improvements!

BTW, here’s a PR for the suggestions on tab indexing (here implemented as index 8, after the ‘cancel’ focus) and adding :focus styling – Something like this would suit my needs as a keyboard user.

https://github.com/discourse/discourse/pull/5575

[pfaffman (Jay Pfaffman)]

@awesomerobot

One small thing: would anyone be opposed to making this stand out slightly more as a button?

That was my first reaction.

@codinghorror

This is an extreme power user feature, not something we want to call a lot of extra attention to.

I disagree. Replying privately to a public message seems like a fairly useful thing to do (but maybe we don’t want to encourage private conversation?), and the only way that I know to do that is with the .

And when I was teaching with Discourse, reply-as-linked-topic was very useful for people to start a new topic with their solution to the exercise.

[codinghorror (Jeff Atwood)]

@pfaffman

Maybe we don’t want to encourage private conversation?

Correct, we don’t want to do that.