Minor issues with the admin's Email Customization

It’s a minor thing, but after saving an email customization, and moving to the next template, the “Saved!” doesn’t go away.

3 Likes

Currently, the preview text is all in bold, regardless of the text’s bold-state

6 Likes

The default subject for Pending Users Reminder and Queued Posts Reminder is just [object Object]

5 Likes

Here’s another mention of object Object, interestly, I’m deploying in English.

@eviltrout fixed this via:

https://github.com/discourse/discourse/commit/8eeb027c653d37452d220a08ae04eafd34b833f9

3 Likes

Fixed via:

https://github.com/discourse/discourse/commit/4bc6cfd71894c3736bd6fcd508eebe0d053ae3c9

3 Likes

This issue was tricky! :challengeaccepted:

It was happening because queued_posts_reminder has two subject keys:

https://github.com/discourse/discourse/blob/master/config/locales/server.en.yml#L1498-L1501

To solve this issue what I did was instead of providing two input boxes for customizing subject keys, I linked the user to the “customize text” page:

Clicking on that link will take user to the “customize text” page with search query pre-filled:


https://github.com/discourse/discourse/commit/86374c90de9535bcc306ff1eda17794c1b08070b

3 Likes