Minor UI bug with manually closing a topic that has a topic timer set for auto close in the future

TurtleStack · February 7, 2024, 9:47pm

The PR has been sent. Thanks!

github.com/discourse/discourse

FIX: Hide timer info on topic status toggle

discourse:main ← turtlestackdev:fix/topic_timer_visible_after_status_toggle

opened 09:46PM - 07 Feb 24 UTC

turtlestackdev

+62 -0

Fix for https://meta.discourse.org/t/minor-ui-bug-with-manually-closing-a-topic-…that-has-a-topic-timer-set-for-auto-close-in-the-future/289482 When an auto close/open timer is set and the user manually opens/closes the topic, the timer info remains displayed until the page is refreshed. The changes here fix that by adding a `@statusUpdate` property to the timer info within the topic template. The `@statusUpdate` property is read in the `topic-timer-info` component. When this value is defined, and the timer `statusType` matches the the topic status, the timer info `showTopicTimer` and `executedAt` values are set to null. The latter is modified to prevent the info from being incorrectly displayed if the user toggles the status back to open. The `@statusUpdate` property is set to the value of the topic `topic_status_update` which is undefined by default. After the topic controller `toggleClosed` function finishes, this value is updated with the return value from the API. This in turn triggers another render of the `topic-timer-info` component which now has the information it needs to hide itself. This does trigger an additional render of the timer info after the hooks are fired, but I felt it was acceptable. Three acceptance tests have been added to topic-edit-timer-test.js. - auto-close timer is hidden after manually closing the topic - auto-open timer is hidden after manually opening the topic - auto-close timer is hidden after manually closing and then re-opening the topic The topic test fixture needed a minor adjustment to enable toggling the topic status.

Topic		Replies	Views
Closing a topic manually doesn't clear the topic timer's automatic closure ux topic-timers	5	703	December 11, 2018
Also update topic timer UI for auto-delete replies, auto-close after last post ux topic-timers	2	943	January 17, 2022
Temporary Timed Closure of topic not re-opening topic bug	3	821	August 23, 2017
Automatically close solved topics after N hours feature solved	11	2981	June 1, 2017
Live Topic Timer theme-component topic-timers	16	3328	March 29, 2021

Minor UI bug with manually closing a topic that has a topic timer set for auto close in the future

Related Topics