Thrilled about this!
Small note – I think there’s a missing closing </div>
for .published-page-header
, before .published-page-body
.
The spec for the css selector is “the title and authorship information”, but currently it’s modifying the full topic (including the body).
screenshot from firefox
4 Likes
Are we missing a div here @tshenry ?
7 Likes
tshenry
(Taylor)
June 25, 2020, 5:38pm
3
I don’t think it’s missing per se, just misplaced. I’ll create a PR with what I believe was intended and hopefully we can get this fixed in short order!
Edit: PR is merged and backported to stable!
discourse:master
← discourse:published-page-fix
opened 06:26PM - 25 Jun 20 UTC
According to the [Page Publishing Meta topic](https://meta.discourse.org/t/page-… publishing/151971), the spec for the `published-page-header` element is "title and authorship information." This change will move `published-page-body` to be a sibling of `published-page-header` since it does not seem correct to include `published-page-body` as a child.
**Before:**
<img width="825" alt="Screen Shot 2020-06-25 at 11 05 04 AM" src="https://user-images.githubusercontent.com/22733864/85777320-601d2200-b6d6-11ea-9224-ecbd406c5991.png">
**After:**
<img width="823" alt="Screen Shot 2020-06-25 at 11 06 21 AM" src="https://user-images.githubusercontent.com/22733864/85777339-64e1d600-b6d6-11ea-8a34-fcb48036f6c0.png">
16 Likes