Moderator email viewing rights changed?

[codinghorror (Jeff Atwood)]

Probably we should fix the bugs there cc @zogstrip

Go ahead and update the copy to indicate intent here for sure @jomaxro you are not blocked.

[zogstrip (Régis Hanol)]

@gerhard can you ensure moderators can see the when the “moderators_view_emails” site setting is enabled?

Also make sure that any “view email” action is properly logged.

[cpradio]

Just want to point something out, this isn’t just the /admin/users/list, but all lists for users in the Admin Area, Suspect, Staff, Silenced, Staged, etc.

[gerhard (Gerhard Schlager)]

@jomaxro

/admin/users/list : does not show emails, does log check email without context. Reloads list of users.

This is fixed: https://github.com/discourse/discourse/commit/457e6c7b37a66553325ef13e579585b2270ef410

@jomaxro

/u/{username}/preferences : does not show email, does not log check email . Reloads entire page (including header).

I couldn’t reproduce this. It’s the same code path as in the first two cases, so I’m not sure why it didn’t work for you.

[jomaxro (Joshua Rosenfeld)]

I couldn’t reproduce this. It’s the same code path as in the first two cases, so I’m not sure why it didn’t work for you.

I can’t repro it either now…strange.

[jomaxro (Joshua Rosenfeld)]

Per https://github.com/discourse/discourse/commit/c34a6ba674ecf78eb4d561b9f633cc497e973b74 we have renamed the site setting to make it less confusing. The site setting moderators view emails now determines whether moderators can view emails. The site setting show_email_on_profile no longer exists.