Your initial thought was correct. Can you confirm that the site setting
moderators_view_emails is enabled on your sandbox. With that setting disabled (default) as a moderator I cannot see emails anywhere. With the setting enabled, the “show emails” button reappears for mods, clicking it on the admin user list does not reveal emails, but clicking it on admin user page and user profile does reveal it. Oddly enough clicking on the button in user preferences also doesn’t work.
This is indeed confusing, inconsistent, and the setting’s description isn’t exactly clear. @codinghorror, two suggestions:
- Fix the site setting
moderators_view_emails so that it matches it’s description. It should only show the “show email” button on a user’s profile page, nothing else.
- Add a boolean site setting for
moderator view email. When enabled, mods can access emails everywhere admins can. When disabled (default), no email access regardless of other settings.
#1 seems more pressing (the setting adds broken buttons for moderators), #2 could perhaps be a 2.3 feature? It has been requested a few times since we started hiding emails from moderators.