Multiple users liking a single post notification

Did some poking around in the code for notifications and noticed that this condition is never met in widgets⁩/notification-item.js.es6. Running 2.3.8.

Screen Shot 2020-04-22 at 7.40.54 PM

Doing a console.log of data object shows that data.count is usually undefined unless it’s a consolidated notification that one user likes more than one of your posts. Also username2 is not defined in the data object.

Is this notification type being phased out?

Is this dead code @eviltrout?

2 Likes

I think this stuff happens if you have notify on every like enabled. (I use this on meta)

4 Likes

We are definitely sending out username2 in some circumstances:

Thanks for responding @codinghorror @eviltrout. I realized this seems to have been refactored and is different in 2.4.2 now.

Moving this to #dev discussion.